Skip to content
Check and test

use more recent version of halo2wrong #133

Sign in to view logs

use more recent version of halo2wrong

use more recent version of halo2wrong #133

GitHub Actions / clippy failed Dec 21, 2023 in 0s

clippy

3 errors, 10 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 3
Warning 10
Note 0
Help 0

Versions

  • rustc 1.74.1 (a28077b28 2023-12-04)
  • cargo 1.74.1 (ecb9851af 2023-10-18)
  • clippy 0.1.74 (a28077b 2023-12-04)

Annotations

Check warning on line 627 in ff-uint_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> ff-uint_derive/src/lib.rs:627:37
    |
627 |     let montgomery_impl = mont_impl(&cratename, limbs);
    |                                     ^^^^^^^^^^ help: change this to: `cratename`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 626 in ff-uint_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> ff-uint_derive/src/lib.rs:626:34
    |
626 |     let multiply_impl = mul_impl(&cratename, quote! {self}, quote! {other}, limbs);
    |                                  ^^^^^^^^^^ help: change this to: `cratename`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 625 in ff-uint_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> ff-uint_derive/src/lib.rs:625:34
    |
625 |     let squaring_impl = sqr_impl(&cratename, quote! {self}, limbs);
    |                                  ^^^^^^^^^^ help: change this to: `cratename`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 614 in ff-uint_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant closure 

warning: redundant closure
   --> ff-uint_derive/src/lib.rs:614:34
    |
614 |             (0..(limbs * 2)).map(|i| get_temp(i)),
    |                                  ^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `get_temp`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

Check warning on line 567 in ff-uint_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant closure 

warning: redundant closure
   --> ff-uint_derive/src/lib.rs:567:34
    |
567 |             (0..(limbs * 2)).map(|i| get_temp(i)),
    |                                  ^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `get_temp`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
    = note: `#[warn(clippy::redundant_closure)]` on by default

Check warning on line 244 in ff-uint_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual implementation of an assign operation 

warning: manual implementation of an assign operation
   --> ff-uint_derive/src/lib.rs:244:9
    |
244 |         t = t >> 1;
    |         ^^^^^^^^^^ help: replace it with: `t >>= 1`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern

Check warning on line 178 in ff-uint_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual implementation of an assign operation 

warning: manual implementation of an assign operation
   --> ff-uint_derive/src/lib.rs:178:9
    |
178 |         v = v >> 1;
    |         ^^^^^^^^^^ help: replace it with: `v >>= 1`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern

Check warning on line 156 in ff-uint_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual implementation of an assign operation 

warning: manual implementation of an assign operation
   --> ff-uint_derive/src/lib.rs:156:9
    |
156 |         v = v >> 64;
    |         ^^^^^^^^^^^ help: replace it with: `v >>= 64`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern

Check failure on line 1 in /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`#![feature]` may not be used on the stable release channel 

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs:1:12
  |
1 | #![feature(asm)]
  |            ^^^

Check warning on line 141 in ff-uint_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement 

warning: unneeded `return` statement
   --> ff-uint_derive/src/lib.rs:141:15
    |
141 |         }) => return s.value(),
    |               ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
    |
141 |         }) => s.value(),
    |               ~~~~~~~~~

Check warning on line 87 in ff-uint_derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual implementation of an assign operation 

warning: manual implementation of an assign operation
  --> ff-uint_derive/src/lib.rs:87:13
   |
87 |             cur = cur << 64;
   |             ^^^^^^^^^^^^^^^ help: replace it with: `cur <<= 64`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
   = note: `#[warn(clippy::assign_op_pattern)]` on by default

Check failure on line 2 in /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`#![feature]` may not be used on the stable release channel 

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs:2:1
  |
2 | #![feature(asm_const)]
  | ^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 1 in /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`#![feature]` may not be used on the stable release channel 

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs:1:1
  |
1 | #![feature(asm)]
  | ^^^^^^^^^^^^^^^^
View more details on GitHub Actions