-
-
Notifications
You must be signed in to change notification settings - Fork 407
Adds static modifier to semantic tokens where appropriate. #2260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Techatrix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test coverage for semantic tokens should be updated. You can use zig build test -Dtest-filter="lsp_features.semantic_tokens" to run them.
I pushed a commit to your PR that should improve the error message from the tests when it reports incorrect token modifiers. Hope that helps.
Also be aware that this PR will need to be rebased if #2244 is merged.
|
I've implemented all the tests. |
Techatrix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for your work.
This enables coloring local and static variables differently:

It does not affect VS Code's default themes:
