Skip to content

Conversation

@lakshya1goel
Copy link
Contributor

Fixes: #1319

Screenshot

Image

@lakshya1goel lakshya1goel force-pushed the issue1319 branch 2 times, most recently from 53dd04c to fefccea Compare February 6, 2025 18:07
Copy link
Collaborator

@chrisbobbe chrisbobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n: Update label to "Messages with yourself" in DM header

commit-message nit: choose a different prefix than i18n. This commit involves the i18n subsystem, because it's changing a UI string and we translate those—but it isn't a change in the i18n subsystem itself. How about msglist.

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Feb 6, 2025

Also, updating the PR title to remove [nfc]—this is a behavior change, not a pure refactor.

@chrisbobbe chrisbobbe changed the title i18n [nfc]: Update label to 'Messages with yourself' in DM header i18n: Update label to 'Messages with yourself' in DM header Feb 6, 2025
@lakshya1goel lakshya1goel changed the title i18n: Update label to 'Messages with yourself' in DM header msglist: Update label to 'Messages with yourself' in DM header Feb 10, 2025
@chrisbobbe
Copy link
Collaborator

Thanks, LGTM! Marking for Greg's review.

@chrisbobbe chrisbobbe requested a review from gnprice February 10, 2025 21:20
@chrisbobbe chrisbobbe added the integration review Added by maintainers when PR may be ready for integration label Feb 10, 2025
@chrisbobbe chrisbobbe added this to the M5: Launch milestone Feb 10, 2025
Copy link
Member

@gnprice gnprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! A few small comments.


There's a TODO comment where this is used:

    } else {
      // TODO pick string; web has glitchy "You and $yourname"
      title = zulipLocalizations.messageListGroupYouWithYourself;

We're taking care of that TODO with this change, so the comment should be deleted.


There was a chat thread where we decided to make this change, right? Let's have the commit message link to that thread.


In the commit message:

Fixes: zulip#1319

It should say just #1319, not zulip#1319 — the "zulip" part is redundant.

@lakshya1goel lakshya1goel force-pushed the issue1319 branch 4 times, most recently from a8eaa7f to 81feafd Compare February 12, 2025 14:16
@lakshya1goel
Copy link
Contributor Author

Thanks for the review @gnprice, pushed the revision, PTAL.

@gnprice
Copy link
Member

gnprice commented Feb 13, 2025

Thanks for the revision! Looks good; merging.

@gnprice gnprice merged commit 1e8397b into zulip:main Feb 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration review Added by maintainers when PR may be ready for integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom headers for messages with yourself

3 participants