Skip to content

msglist: Update label to 'Messages with yourself' in DM header #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025
Merged

msglist: Update label to 'Messages with yourself' in DM header #1323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/l10n/app_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@
"others": {"type": "String", "example": "Alice, Bob"}
}
},
"messageListGroupYouWithYourself": "You with yourself",
"messageListGroupYouWithYourself": "Messages with yourself",
"@messageListGroupYouWithYourself": {
"description": "Message list recipient header for a DM group that only includes yourself."
},
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ abstract class ZulipLocalizations {
/// Message list recipient header for a DM group that only includes yourself.
///
/// In en, this message translates to:
/// **'You with yourself'**
/// **'Messages with yourself'**
String get messageListGroupYouWithYourself;

/// Content validation error message when the message is too long.
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_ar.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
}

@override
String get messageListGroupYouWithYourself => 'You with yourself';
String get messageListGroupYouWithYourself => 'Messages with yourself';

@override
String get contentValidationErrorTooLong => 'Message length shouldn\'t be greater than 10000 characters.';
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_en.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
}

@override
String get messageListGroupYouWithYourself => 'You with yourself';
String get messageListGroupYouWithYourself => 'Messages with yourself';

@override
String get contentValidationErrorTooLong => 'Message length shouldn\'t be greater than 10000 characters.';
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_ja.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
}

@override
String get messageListGroupYouWithYourself => 'You with yourself';
String get messageListGroupYouWithYourself => 'Messages with yourself';

@override
String get contentValidationErrorTooLong => 'Message length shouldn\'t be greater than 10000 characters.';
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_nb.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
}

@override
String get messageListGroupYouWithYourself => 'You with yourself';
String get messageListGroupYouWithYourself => 'Messages with yourself';

@override
String get contentValidationErrorTooLong => 'Message length shouldn\'t be greater than 10000 characters.';
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_sk.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ class ZulipLocalizationsSk extends ZulipLocalizations {
}

@override
String get messageListGroupYouWithYourself => 'You with yourself';
String get messageListGroupYouWithYourself => 'Messages with yourself';

@override
String get contentValidationErrorTooLong => 'Message length shouldn\'t be greater than 10000 characters.';
Expand Down
1 change: 0 additions & 1 deletion lib/widgets/message_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,7 +1179,6 @@ class DmRecipientHeader extends StatelessWidget {
.sorted()
.join(", "));
} else {
// TODO pick string; web has glitchy "You and $yourname"
title = zulipLocalizations.messageListGroupYouWithYourself;
}

Expand Down