Skip to content

Conversation

@axel-lauer
Copy link
Contributor

@axel-lauer axel-lauer commented Jul 23, 2025

Description

Add custom CMOR table for above-ground biomass (variable agb). This is needed for the ESACCI-BIOMASS CMORizer (ESMValGroup/ESMValTool#4121).

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

@axel-lauer axel-lauer requested a review from schlunma July 23, 2025 07:53
@axel-lauer axel-lauer added the cmor Related to the CMOR standard label Jul 23, 2025
@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.45%. Comparing base (357b8bd) to head (65693e7).
⚠️ Report is 60 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2783   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files         260      260           
  Lines       15496    15496           
=======================================
  Hits        14792    14792           
  Misses        704      704           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Axel, looks good to me! I wonder if there's a little description of this variable available in the dataset that you can use as a comment here? For example, does this only include vegetation or any living beings?

@schlunma schlunma added this to the v2.13.0 milestone Jul 23, 2025
@jlenh
Copy link
Contributor

jlenh commented Aug 18, 2025

Thanks Axel, looks good to me! I wonder if there's a little description of this variable available in the dataset that you can use as a comment here? For example, does this only include vegetation or any living beings?

@axel-lauer Any input on the point raised by Manuel so we can merge the PR for the 2.13 release?

@axel-lauer
Copy link
Contributor Author

Thanks Axel, looks good to me! I wonder if there's a little description of this variable available in the dataset that you can use as a comment here? For example, does this only include vegetation or any living beings?

@axel-lauer Any input on the point raised by Manuel so we can merge the PR for the 2.13 release?

Good point! According to the data description, above-ground biomass is defined as the "amount of living biomass (organic matter) stored in vegetation above the soil including stem, stump, branches, bark, seeds and foliage, expressed as dry weight". I added this as a comment to the custom CMOR table: 65693e7

@jlenh
Copy link
Contributor

jlenh commented Aug 18, 2025

Thanks Axel, looks good to me! I wonder if there's a little description of this variable available in the dataset that you can use as a comment here? For example, does this only include vegetation or any living beings?

@axel-lauer Any input on the point raised by Manuel so we can merge the PR for the 2.13 release?

Good point! According to the data description, above-ground biomass is defined as the "amount of living biomass (organic matter) stored in vegetation above the soil including stem, stump, branches, bark, seeds and foliage, expressed as dry weight". I added this as a comment to the custom CMOR table: 65693e7

Perfect, Thanks Axel!

@jlenh jlenh merged commit b19ca87 into main Aug 18, 2025
7 checks passed
@jlenh jlenh deleted the add_var_agb branch August 18, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmor Related to the CMOR standard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants