-
Notifications
You must be signed in to change notification settings - Fork 44
Add custom CMOR table for above-ground biomass (agb) #2783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2783 +/- ##
=======================================
Coverage 95.45% 95.45%
=======================================
Files 260 260
Lines 15496 15496
=======================================
Hits 14792 14792
Misses 704 704 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
schlunma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Axel, looks good to me! I wonder if there's a little description of this variable available in the dataset that you can use as a comment here? For example, does this only include vegetation or any living beings?
Co-authored-by: Manuel Schlund <[email protected]>
@axel-lauer Any input on the point raised by Manuel so we can merge the PR for the 2.13 release? |
Good point! According to the data description, above-ground biomass is defined as the "amount of living biomass (organic matter) stored in vegetation above the soil including stem, stump, branches, bark, seeds and foliage, expressed as dry weight". I added this as a comment to the custom CMOR table: 65693e7 |
Perfect, Thanks Axel! |
Description
Add custom CMOR table for above-ground biomass (variable agb). This is needed for the ESACCI-BIOMASS CMORizer (ESMValGroup/ESMValTool#4121).
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.