-
Notifications
You must be signed in to change notification settings - Fork 146
CMORizer for ESACCI-BIOMASS #4121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
schlunma
approved these changes
Jul 23, 2025
Contributor
schlunma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Axel, looks great! I ran the downloader, CMORizer, and recipe_check_obs successfully. Data looks reasonable to me (I am no expert though).
This can be merged once a new ESMValCore release is available (it requires the agb variable definition).
esmvaltool/cmorizers/data/formatters/datasets/esacci_biomass.py
Outdated
Show resolved
Hide resolved
esmvaltool/cmorizers/data/formatters/datasets/esacci_biomass.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Manuel Schlund <[email protected]>
…lTool into cmorize_esacci_biomass
Co-authored-by: Manuel Schlund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved by scientific reviewer
approved by technical reviewer
observations
requires new ESMValCore release
A new release of ESMValCore is needed to solve this issue/merge this pull request..
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add downloading and reformatting scripts for ESACCI-BIOMASS (above-ground biomass, agb). This PR requires the custom CMOR table for variable agb implemented in ESMValGroup/ESMValCore#2783.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated data reformatting script