Skip to content

Conversation

shajder
Copy link
Contributor

@shajder shajder commented Jul 24, 2025

Related to #2282, according to work plan from here

with CL_INVALID_SAMPLER and sampler argument
@bashbaug
Copy link
Contributor

bashbaug commented Jul 25, 2025

This looks like a duplicate of #2452.

Never mind, I see the difference now.

EwanC
EwanC previously approved these changes Aug 19, 2025
@bashbaug
Copy link
Contributor

Discussed in the August 26th teleconference. Aiming to merge next week.

@shajder shajder requested a review from EwanC September 8, 2025 07:09
EwanC
EwanC previously approved these changes Sep 8, 2025
@bashbaug bashbaug requested a review from lakshmih September 9, 2025 15:41
@bashbaug
Copy link
Contributor

bashbaug commented Sep 9, 2025

Discussed in the September 9th teleconference. OK to merge offline with one more approval.

@bashbaug
Copy link
Contributor

@shajder heads up, this has a merge conflict now that needs to be addressed.

@shajder
Copy link
Contributor Author

shajder commented Sep 11, 2025

@shajder heads up, this has a merge conflict now that needs to be addressed.

Thanks, I will solve conflicts for focused review PRs tomorrow morning

lakshmih
lakshmih previously approved these changes Sep 11, 2025
@shajder shajder dismissed stale reviews from lakshmih and EwanC via 354b01b September 12, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants