Add translation for Intrinsic::{atan,acos,asin,cosh,sinh,tanh} #2657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add translation for atan, acos, asin, cosh, sinh and tanh LLVM intrinsics which are mapped to corresponding OpenCL extended instructions.
MrSidims
reviewed
Aug 1, 2024
There was a problem hiding this comment.
Thanks for the contribution! Lets also add these intrinsics to the list within getNativeBuiltinIdForIntrinsic function in SPIRVWriter, so when an intrinsic has afn fast-math flag it would be mapped on a native OpenCL builtin, see 6417ada
|
Are there native versions for these OpenCL builtins? It seems to me there aren't. |
MrSidims
approved these changes
Aug 1, 2024
2 tasks
|
Restarting CI with the new HEAD |
|
Merging, will get approve from Sven offline if necessary |
|
Thanks for the review and merging! |
linehill
added a commit
to linehill/SPIRV-LLVM-Translator
that referenced
this pull request
Aug 9, 2024
…osGroup#2657) Add translation for atan, acos, asin, cosh, sinh and tanh LLVM intrinsics which are mapped to corresponding OpenCL extended instructions.
MrSidims
pushed a commit
that referenced
this pull request
Aug 10, 2024
#2669) Add translation for atan, acos, asin, cosh, sinh and tanh LLVM intrinsics which are mapped to corresponding OpenCL extended instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add translation for atan, acos, asin, cosh, sinh and tanh LLVM intrinsics which are mapped to corresponding OpenCL extended instructions.