Prevent TimeStamps from being modified
#821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our `TimeStamp` type is internally an `Instant`. The representation of `Instant` depends on the platform, but for many platforms it internally consists of unsigned numbers. For WASI its worse, because the moment the WASI VM starts, the time starts at 0. This means any subtraction from the time results in a numeric underflow and might panic. To prevent this from happening, `TimeStamp`s can no longer be manually modified, they always represent valid points in time.
CryZe
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
TimeStamptype is internally anInstant. The representation ofInstantdepends on the platform, but for many platforms it internally consists of unsigned numbers. For WASI its worse, because the moment the WASI VM starts, the time starts at 0. This means any subtraction from the time results in a numeric underflow and might panic. To prevent this from happening,TimeStamps can no longer be manually modified, they always represent valid points in time.