Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 21, 2026

  • Update base image from ROCm 6.3.1 to ROCm 7.1 (Ubuntu 24.04, Python 3.13)
  • Add jq installation to the def file
  • Update system packages to match Dockerfile (git, wget, ninja-build, cmake, python3-pip, python3-dev, build-essential)
  • Update Triton git commit hash to match Dockerfile (715f6b1d442601436bf8d462db6ff8e17aec8cfb)
  • Adjust Python environment setup to use pip instead of conda
  • Update environment variables to match Dockerfile
  • Update runscript to use native Apptainer pattern instead of Docker entrypoint
  • Force rebuild by updating the def file version/copyright year and changing base image
  • Remove unnecessary entrypoint script creation (Docker-specific pattern not needed in Apptainer)
Original prompt

This section details on the original issue you should resolve

<issue_title>Update the apptainer def file</issue_title>
<issue_description>1. Install jq
2. the def file is out of date and need to match the main Dockerfile
3. Force rebuilding the apptainer image</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Update apptainer def file to match Dockerfile Update apptainer def file to match Dockerfile Jan 21, 2026
Copilot AI requested a review from mawad-amd January 21, 2026 18:39
@mawad-amd
Copy link
Collaborator

@copilot force overwriting the image file so we test this.

Copy link
Contributor Author

Copilot AI commented Jan 21, 2026

@copilot force overwriting the image file so we test this.

Added --force flag to the apptainer build script. This ensures the image will be overwritten on every build, even if it already exists. (3f2f94a)

Copilot AI requested a review from mawad-amd January 21, 2026 18:58
@mawad-amd mawad-amd marked this pull request as ready for review January 21, 2026 18:59
Copilot AI review requested due to automatic review settings January 21, 2026 18:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the apptainer definition file to align with the main Dockerfile, addressing environment inconsistencies between Docker and Apptainer deployments. The changes upgrade the base ROCm version, migrate from conda to pip-based Python environment management, update Triton to a newer commit, and add the jq package as requested.

Changes:

  • Upgraded base image from ROCm 6.3.1 (Ubuntu 22.04, Python 3.10) to ROCm 7.1 (Ubuntu 24.04, Python 3.13)
  • Migrated Python environment from conda to pip, matching the Dockerfile's approach
  • Updated Triton commit hash and changed installation path from /workspace/triton to /opt/triton
  • Added --force flag to build script to ensure image overwrites on each build

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
apptainer/iris.def Updated base image, system packages (including jq), Triton version, environment variables, and simplified runscript to match Dockerfile
apptainer/build.sh Added --force flag to ensure image is overwritten on every build

@mawad-amd
Copy link
Collaborator

@copilot disable all gluon tests.

Copy link
Contributor Author

Copilot AI commented Jan 24, 2026

@copilot disable all gluon tests.

Disabled the external gluon validation test job by adding if: false condition to the workflow. (f296db8)

Copilot AI changed the title Update apptainer def file to match Dockerfile Update apptainer def file to match Dockerfile and disable gluon tests Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the apptainer def file

2 participants