Merged
Conversation
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update apptainer def file to match Dockerfile
Update apptainer def file to match Dockerfile
Jan 21, 2026
Collaborator
|
@copilot force overwriting the image file so we test this. |
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Contributor
Author
mawad-amd
reviewed
Jan 21, 2026
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the apptainer definition file to align with the main Dockerfile, addressing environment inconsistencies between Docker and Apptainer deployments. The changes upgrade the base ROCm version, migrate from conda to pip-based Python environment management, update Triton to a newer commit, and add the jq package as requested.
Changes:
- Upgraded base image from ROCm 6.3.1 (Ubuntu 22.04, Python 3.10) to ROCm 7.1 (Ubuntu 24.04, Python 3.13)
- Migrated Python environment from conda to pip, matching the Dockerfile's approach
- Updated Triton commit hash and changed installation path from
/workspace/tritonto/opt/triton - Added
--forceflag to build script to ensure image overwrites on each build
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apptainer/iris.def | Updated base image, system packages (including jq), Triton version, environment variables, and simplified runscript to match Dockerfile |
| apptainer/build.sh | Added --force flag to ensure image is overwritten on every build |
mawad-amd
reviewed
Jan 21, 2026
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
mawad-amd
reviewed
Jan 22, 2026
mawad-amd
reviewed
Jan 22, 2026
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Collaborator
|
@copilot disable all gluon tests. |
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
Update apptainer def file to match Dockerfile
Update apptainer def file to match Dockerfile and disable gluon tests
Jan 24, 2026
mawad-amd
reviewed
Jan 24, 2026
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
mawad-amd
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.