-
Notifications
You must be signed in to change notification settings - Fork 31
Update apptainer def file to match Dockerfile and disable gluon tests #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: mawad-amd <[email protected]>
Co-authored-by: mawad-amd <[email protected]>
|
@copilot force overwriting the image file so we test this. |
Co-authored-by: mawad-amd <[email protected]>
Co-authored-by: mawad-amd <[email protected]>
Co-authored-by: mawad-amd <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the apptainer definition file to align with the main Dockerfile, addressing environment inconsistencies between Docker and Apptainer deployments. The changes upgrade the base ROCm version, migrate from conda to pip-based Python environment management, update Triton to a newer commit, and add the jq package as requested.
Changes:
- Upgraded base image from ROCm 6.3.1 (Ubuntu 22.04, Python 3.10) to ROCm 7.1 (Ubuntu 24.04, Python 3.13)
- Migrated Python environment from conda to pip, matching the Dockerfile's approach
- Updated Triton commit hash and changed installation path from
/workspace/tritonto/opt/triton - Added
--forceflag to build script to ensure image overwrites on each build
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apptainer/iris.def | Updated base image, system packages (including jq), Triton version, environment variables, and simplified runscript to match Dockerfile |
| apptainer/build.sh | Added --force flag to ensure image is overwritten on every build |
…hm access Co-authored-by: mawad-amd <[email protected]>
Co-authored-by: mawad-amd <[email protected]>
Co-authored-by: mawad-amd <[email protected]>
Co-authored-by: mawad-amd <[email protected]>
|
@copilot disable all gluon tests. |
Co-authored-by: mawad-amd <[email protected]>
Co-authored-by: mawad-amd <[email protected]>
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.