-
Notifications
You must be signed in to change notification settings - Fork 31
Update apptainer def file #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
19
commits into
main
Choose a base branch
from
copilot/update-apptainer-def-file
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−17
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3f93ea0
Initial plan
Copilot 67778ab
Update apptainer def file to match Dockerfile and add jq
Copilot 6824b7d
Fix apptainer runscript to properly pass arguments
Copilot 3f2f94a
Add --force flag to apptainer build script to overwrite existing image
Copilot d531426
Remove unnecessary entrypoint script from apptainer def file
Copilot 1504d62
Force rebuild in container_build.sh script
Copilot 5f67afd
Revert changes to container_build.sh script
Copilot f25dd31
Increase Apptainer overlay size from 1GB to 8GB to fix disk space issues
Copilot 3b281e1
Add --writable-tmpfs flag to fix shared memory issues in Apptainer
Copilot 4fd56e7
Fix shared memory by bind mounting /dev/shm instead of using --writab…
Copilot 230c41f
Use --no-mount dev and explicitly bind device paths for proper /dev/s…
Copilot f9ec46a
Revert --no-mount dev and use default /dev handling with NCCL env vars
Copilot 6c587ea
Revert changes to container_exec.sh as requested
Copilot d68d21a
Remove --force flag from apptainer build script
Copilot 003b5a3
bump overlay size
mawad-amd f296db8
Disable gluon validation tests
Copilot 42b8135
Revert disabling of gluon validation tests
Copilot 5497c0b
Update iris.def
mawad-amd eb23b1c
Update iris.def
mawad-amd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,35 +1,51 @@ | ||
| # SPDX-License-Identifier: MIT | ||
| # Copyright (c) 2025 Advanced Micro Devices, Inc. All rights reserved. | ||
| # Copyright (c) 2025-2026 Advanced Micro Devices, Inc. All rights reserved. | ||
|
|
||
| Bootstrap: docker | ||
| From: rocm/pytorch:rocm6.3.1_ubuntu22.04_py3.10_pytorch | ||
| From: rocm/pytorch:rocm7.1_ubuntu24.04_py3.13_pytorch_release_2.9.1 | ||
|
|
||
| %post | ||
| /bin/bash -c " | ||
| apt-get update && apt-get install -y git | ||
| export TRITON_PATH=/workspace/triton | ||
| conda env list | ||
| source /opt/conda/bin/activate py_3.10 | ||
| conda install -y -n py_3.10 -c conda-forge jupyter ninja cmake wheel | ||
| # Set environment variables | ||
| export TRITON_PATH=/opt/triton | ||
| export ROCM_PATH=/opt/rocm | ||
| export LD_LIBRARY_PATH=\$ROCM_PATH/lib:\$LD_LIBRARY_PATH | ||
| export PATH=\"\$ROCM_PATH/bin:\$PATH\" | ||
|
|
||
| # Install system packages | ||
| apt-get update && \ | ||
| DEBIAN_FRONTEND=noninteractive apt-get install -y \ | ||
| git wget ninja-build cmake python3-pip python3-dev build-essential jq && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Create groups if they don't exist | ||
| groupadd -r video 2>/dev/null || true | ||
| groupadd -r render 2>/dev/null || true | ||
|
|
||
| # Install Python packages with pip | ||
| pip3 install --upgrade pip && \ | ||
| pip3 install wheel jupyter | ||
|
|
||
| # Clone and install Triton | ||
| cd /opt | ||
| git clone https://github.com/triton-lang/triton.git \$TRITON_PATH | ||
| cd \$TRITON_PATH | ||
| git checkout dd5823453bcc7973eabadb65f9d827c43281c434 | ||
| pip install -e . | ||
| wget https://github.com/ROCm/rocprofiler-systems/releases/download/rocm-6.3.1/rocprofiler-systems-install.py | ||
| python3 ./rocprofiler-systems-install.py --prefix /opt/rocprofiler-systems --rocm 6.3 | ||
| git checkout aafec417bded34db6308f5b3d6023daefae43905 | ||
| pip3 install -e . | ||
| " | ||
|
|
||
| %environment | ||
| # Define environment variables | ||
| export TRITON_PATH=/workspace/triton | ||
| export PYTHONPATH=$TRITON_PATH/python/ | ||
| export LD_LIBRARY_PATH=/opt/rocm/lib:$LD_LIBRARY_PATH | ||
| export TRITON_PATH=/opt/triton | ||
| export ROCM_PATH=/opt/rocm | ||
| export PATH=/opt/conda/envs/py_3.10/bin:/opt/rocm/bin:$PATH | ||
| export PYTHONPATH=$TRITON_PATH | ||
| export LD_LIBRARY_PATH=$ROCM_PATH/lib:$LD_LIBRARY_PATH | ||
| export PATH="$ROCM_PATH/bin:$PATH" | ||
| export OMPI_MCA_mtl="^ofi" | ||
| export OMPI_MCA_pml="ob1" | ||
| export OMPI_ALLOW_RUN_AS_ROOT_CONFIRM=1 | ||
| export OMPI_ALLOW_RUN_AS_ROOT=1 | ||
|
|
||
| %runscript | ||
| echo "Welcome to the ROCm-aware Apptainer image!" | ||
| source /opt/conda/bin/activate py_3.10 | ||
| exec "$@" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.