Conversation
If a node has disabled API Authentication, then algod.token doesn't exist, but genesis.json should always exist
feat: Added algod config to StateModel for displaying items in the UI
This reverts commit 543a603.
Co-authored-by: Tasos Bitsios <tasos.bitsios@algorand.foundation>
Mostly nil reference checks, most (if not all) would be impossible to happen, but better safe than sorry. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fix: Correct typo
chore: Restyle status panel
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
===========================================
+ Coverage 34.75% 45.28% +10.52%
===========================================
Files 89 93 +4
Lines 6974 5850 -1124
===========================================
+ Hits 2424 2649 +225
+ Misses 4417 2930 -1487
- Partials 133 271 +138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // Should be P2P and WS | ||
| end = style.Red.Render("Network/Config Mismatch") + " " | ||
| } else if isP2PEnabled && hasSomeData && (!hasP2PData || hasP2PData) { | ||
| } else if isP2PEnabled && hasSomeData && (!hasP2PData || hasWSData) { |
There was a problem hiding this comment.
Why do we need !hasP2PData here? Looks benign but it feels like we should just want (is P2P enabled && has non-p2p data)
There was a problem hiding this comment.
Would be good to eventually simplify this logic a bit (and in sibling conditionals) but not going to hold the release for this
There was a problem hiding this comment.
Yeah it got a bit confusing unfortunately, I'm sure I can tidy this up next tine. The logic is at least all clear to me like this (minus this typo I was fixing). Essentially the the hasSomeData is used as a flag to make sure we're not checking the actual conditional logic too early when it first starts up. Then for each if-statement I'm making sure the correct data is being received for the configuration. Should have probably nested it all inside one "hasSomeData" check.
3 participants
Adds P2P Hybrid configuration, improved status UI, various other bug fixes.