ENT-12601: Added workflow to lint shell scripts

[larsewi]

Example output from check_scripts.sh:

$ ./user-scripts/check-scripts.sh
--- ./user-scripts/../build-scripts/produce-debug-symbols.orig
+++ ./user-scripts/../build-scripts/produce-debug-symbols
@@ -4,8 +4,7 @@
 . detect-environment
 . compile-options

-if [ $BUILD_TYPE != "RELEASE" ]
-then
+if [ $BUILD_TYPE != "RELEASE" ]; then
     echo "Debug symbols not requested"
     exit 0
 else

File 'produce-debug-symbols' requires formatting.
Do you wish to format 'produce-debug-symbols'? [y/N] y
Formatting file 'produce-debug-symbols'...

In ./user-scripts/../build-scripts/produce-debug-symbols line 7:
if [ $BUILD_TYPE != "RELEASE" ]; then
     ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
if [ "$BUILD_TYPE" != "RELEASE" ]; then

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

File 'produce-debug-symbols' requires manual intervention.
Press any key to continue...

[larsewi]

@cf-bottom Jenkins with exotics please :)

[cf-bottom]

Alright, I triggered a build:

(with exotics)

Jenkins: https://ci.cfengine.com/job/pr-pipeline/12614/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12614/

[craigcomstock]

lets move the find files and lint that is in yaml to a script/makefile so mortals can run it.

[larsewi]

Try again

[craigcomstock]

cancelled the job because two exotics failed testing-pr because of a buildscripts error I am fixing in #1894 and jenkins needs to be restarted.

[craigcomstock]

@cf-bottom jenkins exotics

[cf-bottom]

Sure, I triggered a build:

(with exotics)

Jenkins: https://ci.cfengine.com/job/pr-pipeline/12632/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12632/