Skip to content

allow underscores in names #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 19, 2025
Merged

allow underscores in names #66

merged 7 commits into from
Feb 19, 2025

Conversation

cornfeedhobo
Copy link
Contributor

what

  • allow underscores in log group names

why

  • I created a lambda with underscores in the name, which is auto-creating a log group to match, yet the cloudposse lambda module was creating a group without underscores, which was useless.

references

@cornfeedhobo cornfeedhobo requested review from a team as code owners January 12, 2025 20:52
@mergify mergify bot added the triage Needs triage label Jan 12, 2025
@RoseSecurity
Copy link

/terratest

@cornfeedhobo
Copy link
Contributor Author

cornfeedhobo commented Jan 17, 2025 •
edited
Loading

I'm force pushing to re-trigger tests

@RoseSecurity
Copy link

/terratest

@cornfeedhobo
Copy link
Contributor Author

I have no idea what to do to make this happy. It looks like this is erroring out because of permissions, but ... is this pointed at an instance of localstack or something?

@RoseSecurity
Copy link

Let me talk to the team and see how we can resolve this. Thank you for the contribution!

@goruha
Copy link
Member

goruha commented Jan 30, 2025

/terratest

1 similar comment
@goruha
Copy link
Member

goruha commented Feb 19, 2025

/terratest

@goruha goruha added the bugfix Change that restores intended behavior label Feb 19, 2025
@goruha
Copy link
Member

goruha commented Feb 19, 2025

/terratest

@goruha
Copy link
Member

goruha commented Feb 19, 2025

/terratest

@mergify mergify bot removed the triage Needs triage label Feb 19, 2025
@goruha goruha merged commit d70ec22 into cloudposse:main Feb 19, 2025
26 checks passed
@github-actions GitHub Actions
Copy link

These changes were released in v0.6.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gberenice gberenice gberenice approved these changes

@kevcube kevcube Awaiting requested review from kevcube kevcube is a code owner automatically assigned from cloudposse/contributors

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
bugfix Change that restores intended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cornfeedhobo @RoseSecurity @goruha @gberenice