Phase2 Single_Tau_Trigger Path Added#49569
Phase2 Single_Tau_Trigger Path Added#49569Chihwan-An wants to merge 1 commit intocms-sw:CMSSW_15_1_Xfrom
Conversation
|
A new Pull Request was created by @Chihwan-An for CMSSW_15_1_X. It involves the following packages:
@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
cms-bot internal usage |
|
You'd need to provide a PR to 16_0 first, then denote this PR as its backport. |
There was a problem hiding this comment.
@Chihwan-An
Indeed as Martin said, you need to first produce a PR for master (currently CMSSW_16_0_X). Also why do you need this in CMSSW_15_1_X?
In my opinion it's not needed (so please close this one).
Also here are some comments. Please apply them before opening the PR in master.
| inputTag = cms.InputTag("hltHpsSelectedPFTauLooseTauWPDeepTau"), | ||
| saveTags = cms.bool(True), | ||
| triggerType = cms.int32(84) | ||
| ) No newline at end of file |
| MaxEta = cms.double(2.1), | ||
| MaxMass = cms.double(-1.0), | ||
| MinE = cms.double(-1.0), | ||
| MinEta = cms.double(-1.0), |
There was a problem hiding this comment.
why is MaxEta = 2.1, but MinEta = -1.0?
Why the asymmetric cut?
There was a problem hiding this comment.
As I Know , MinEta (-1.0) means default value of minmum value.
There was a problem hiding this comment.
As I Know , MinEta (-1.0) means default value of minmum value.
Checking the code, this doesn't seem to be the case.
and
cmssw/HLTrigger/HLTfilters/plugins/HLTSinglet.cc
Lines 145 to 149 in ff1c182
which means that:
- if
MaxEta> 0, then accept for |η|<MaxEta - if
MinEta> 0, then accept for |η|>MinEta
the choice of parameter names is not great. IMHO WithinEta and OutsideOfEta might be better choices. Something to consider when we're free to develop outside of the constraint to support Run3.
| hltPreLooseDeepTauPFTauHPS150L2NNeta2p1 = cms.EDFilter("HLTPrescaler", | ||
| L1GtReadoutRecordTag = cms.InputTag("hltGtStage2Digis"), | ||
| offset = cms.uint32(0) | ||
| ) No newline at end of file |
There was a problem hiding this comment.
this whole file is useless at the moment, we don't have prescales in the phase-2 menu.
Please remove.
|
|
||
|
|
There was a problem hiding this comment.
please remove empty lines.
Thanks for nice comments . |
I think it is better to PR to 16_0_X , I'll make new PR for that version. Thanks. |
Added Single Tau Trigger path for Phase2 , worked with Tau HLT Phase2 development group.
It was tested in miniAOD in CMSSW_15_1_0_pre4 and NanoAOD in CMSSW_16_0_0_pre2 , with Z'to tautau samples.
CMSSW_16_0_0_pre2 version was used to check trigger efficiency , which CMSSW_15_1_0_pre4 has not full resource to get 'genvistau' object .
Trigger Efficiency had 48.7% .