Skip to content

Phase2 Single_Tau_Trigger Path Added#49569

Closed
Chihwan-An wants to merge 1 commit intocms-sw:CMSSW_15_1_Xfrom
Chihwan-An:singletau_trigger_150pt
Closed

Phase2 Single_Tau_Trigger Path Added#49569
Chihwan-An wants to merge 1 commit intocms-sw:CMSSW_15_1_Xfrom
Chihwan-An:singletau_trigger_150pt

Conversation

@Chihwan-An
Copy link

Added Single Tau Trigger path for Phase2 , worked with Tau HLT Phase2 development group.

It was tested in miniAOD in CMSSW_15_1_0_pre4 and NanoAOD in CMSSW_16_0_0_pre2 , with Z'to tautau samples.

CMSSW_16_0_0_pre2 version was used to check trigger efficiency , which CMSSW_15_1_0_pre4 has not full resource to get 'genvistau' object .

Trigger Efficiency had 48.7% .

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2025

A new Pull Request was created by @Chihwan-An for CMSSW_15_1_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2025

cms-bot internal usage

@Martin-Grunewald
Copy link
Contributor

You'd need to provide a PR to 16_0 first, then denote this PR as its backport.
Also, please add in the description the link to the TSG presentation where this path was discussed.

Copy link
Contributor

@mmusich mmusich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chihwan-An
Indeed as Martin said, you need to first produce a PR for master (currently CMSSW_16_0_X). Also why do you need this in CMSSW_15_1_X?
In my opinion it's not needed (so please close this one).
Also here are some comments. Please apply them before opening the PR in master.

inputTag = cms.InputTag("hltHpsSelectedPFTauLooseTauWPDeepTau"),
saveTags = cms.bool(True),
triggerType = cms.int32(84)
) No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a newline is missing here.

MaxEta = cms.double(2.1),
MaxMass = cms.double(-1.0),
MinE = cms.double(-1.0),
MinEta = cms.double(-1.0),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is MaxEta = 2.1, but MinEta = -1.0?
Why the asymmetric cut?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I Know , MinEta (-1.0) means default value of minmum value.

Copy link
Contributor

@sakura-ngt sakura-ngt Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I Know , MinEta (-1.0) means default value of minmum value.

Checking the code, this doesn't seem to be the case.

typedef HLTSinglet<PFTau> HLT1PFTau;

and

for (; i != objects->end(); i++) {
if ((i->energy() >= min_E_) && (i->pt() >= min_Pt_) && (i->mass() >= min_Mass_) &&
((max_Mass_ < 0.0) || (i->mass() <= max_Mass_)) && ((min_Eta_ < 0.0) || (std::abs(i->eta()) >= min_Eta_)) &&
((max_Eta_ < 0.0) || (std::abs(i->eta()) <= max_Eta_))) {
n++;

which means that:

  • if MaxEta > 0, then accept for |η|< MaxEta
  • if MinEta > 0, then accept for |η|> MinEta

the choice of parameter names is not great. IMHO WithinEta and OutsideOfEta might be better choices. Something to consider when we're free to develop outside of the constraint to support Run3.

hltPreLooseDeepTauPFTauHPS150L2NNeta2p1 = cms.EDFilter("HLTPrescaler",
L1GtReadoutRecordTag = cms.InputTag("hltGtStage2Digis"),
offset = cms.uint32(0)
) No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole file is useless at the moment, we don't have prescales in the phase-2 menu.
Please remove.

Comment on lines +44 to +45


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

please remove empty lines.

@Chihwan-An
Copy link
Author

@Chihwan-An Indeed as Martin said, you need to first produce a PR for master (currently CMSSW_16_0_X). Also why do you need this in CMSSW_15_1_X? In my opinion it's not needed (so please close this one). Also here are some comments. Please apply them before opening the PR in master.

Thanks for nice comments .
CMSSW_15_1_X was used due to scram list , there was no CMSSW_16_0_X .
I choosed he most recent avaliable version which was CMSSW_15_1_X .
Sorry for my mistake , I thougt I should make PR in version I used.

@Chihwan-An Chihwan-An closed this Dec 11, 2025
@Chihwan-An
Copy link
Author

You'd need to provide a PR to 16_0 first, then denote this PR as its backport. Also, please add in the description the link to the TSG presentation where this path was discussed.

I think it is better to PR to 16_0_X , I'll make new PR for that version. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants