Skip to content

Phase2 Single_Tau_Trigger Path Added #49569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Chihwan-An wants to merge 1 commit into from
Closed

Phase2 Single_Tau_Trigger Path Added #49569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions HLTrigger/Configuration/python/HLT_75e33/modules/hltHpsPFTau150LooseTauWPDeepTau_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import FWCore.ParameterSet.Config as cms

hltHpsPFTau150LooseTauWPDeepTau = cms.EDFilter("HLT1PFTau",
MaxEta = cms.double(2.1),
MaxMass = cms.double(-1.0),
MinE = cms.double(-1.0),
MinEta = cms.double(-1.0),
Copy link
Contributor

@mmusich mmusich Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is MaxEta = 2.1, but MinEta = -1.0?
Why the asymmetric cut?

Copy link
Author

@Chihwan-An Chihwan-An Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I Know , MinEta (-1.0) means default value of minmum value.

Copy link
Contributor

@sakura-ngt sakura-ngt Dec 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I Know , MinEta (-1.0) means default value of minmum value.

Checking the code, this doesn't seem to be the case.

cmssw/HLTrigger/HLTfilters/plugins/plugins.cc

Line 60 in ff1c182

typedef HLTSinglet<PFTau> HLT1PFTau;

and

cmssw/HLTrigger/HLTfilters/plugins/HLTSinglet.cc

Lines 145 to 149 in ff1c182

for (; i != objects->end(); i++) {
if ((i->energy() >= min_E_) && (i->pt() >= min_Pt_) && (i->mass() >= min_Mass_) &&
((max_Mass_ < 0.0) || (i->mass() <= max_Mass_)) && ((min_Eta_ < 0.0) || (std::abs(i->eta()) >= min_Eta_)) &&
((max_Eta_ < 0.0) || (std::abs(i->eta()) <= max_Eta_))) {
n++;

which means that:

  • if MaxEta > 0, then accept for |η|< MaxEta
  • if MinEta > 0, then accept for |η|> MinEta

the choice of parameter names is not great. IMHO WithinEta and OutsideOfEta might be better choices. Something to consider when we're free to develop outside of the constraint to support Run3.

MinMass = cms.double(-1.0),
MinN = cms.int32(1),
MinPt = cms.double(150.0),
inputTag = cms.InputTag("hltHpsSelectedPFTauLooseTauWPDeepTau"),
saveTags = cms.bool(True),
triggerType = cms.int32(84)
)
Copy link
Contributor

@mmusich mmusich Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a newline is missing here.

7 changes: 7 additions & 0 deletions ...ger/Configuration/python/HLT_75e33/modules/hltPreLooseDeepTauPFTauHPS150L2NNeta2p1_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@

import FWCore.ParameterSet.Config as cms

hltPreLooseDeepTauPFTauHPS150L2NNeta2p1 = cms.EDFilter("HLTPrescaler",
L1GtReadoutRecordTag = cms.InputTag("hltGtStage2Digis"),
offset = cms.uint32(0)
)
Copy link
Contributor

@mmusich mmusich Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole file is useless at the moment, we don't have prescales in the phase-2 menu.
Please remove.

45 changes: 45 additions & 0 deletions ...igger/Configuration/python/HLT_75e33/paths/HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
import FWCore.ParameterSet.Config as cms

from ..sequences.HLTBeginSequence_cfi import *
from ..sequences.HLTRawToDigiSequence_cfi import *
from ..sequences.HLTTICLLocalRecoSequence_cfi import *
from ..sequences.HLTLocalrecoSequence_cfi import *
from ..sequences.HLTTrackingSequence_cfi import *
from ..sequences.HLTMuonsSequence_cfi import *
from ..sequences.HLTParticleFlowSequence_cfi import *
from ..sequences.HLTAK4PFJetsReconstruction_cfi import *
from ..sequences.HLTPFTauHPS_cfi import *
from ..sequences.HLTHPSDeepTauPFTauSequence_cfi import *
from ..sequences.HLTEndSequence_cfi import *
from ..modules.hltL1SingleNNTau150_cfi import *
from ..modules.hltPreLooseDeepTauPFTauHPS150L2NNeta2p1_cfi import *
from ..modules.hltParticleFlowRecHitECALUnseeded_cfi import *
from ..modules.hltParticleFlowClusterECALUncorrectedUnseeded_cfi import *
from ..modules.hltParticleFlowClusterECALUnseeded_cfi import *
from ..modules.hltAK4PFJetsForTaus_cfi import *
from ..modules.hltHpsSelectedPFTauLooseTauWPDeepTau_cfi import *
from ..modules.hltHpsPFTau150LooseTauWPDeepTau_cfi import *

HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1 = cms.Path(
HLTBeginSequence
+ hltL1SingleNNTau150
+ hltPreLooseDeepTauPFTauHPS150L2NNeta2p1
+ HLTRawToDigiSequence
+ HLTTICLLocalRecoSequence
+ HLTLocalrecoSequence
+ HLTTrackingSequence
+ HLTMuonsSequence
+ HLTParticleFlowSequence
+ hltParticleFlowRecHitECALUnseeded
+ hltParticleFlowClusterECALUncorrectedUnseeded
+ hltParticleFlowClusterECALUnseeded
+ HLTAK4PFJetsReconstruction
+ hltAK4PFJetsForTaus
+ HLTPFTauHPS
+ HLTHPSDeepTauPFTauSequence
+ hltHpsSelectedPFTauLooseTauWPDeepTau
+ hltHpsPFTau150LooseTauWPDeepTau
+ HLTEndSequence
)


Comment on lines +44 to +45
Copy link
Contributor

@mmusich mmusich Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

please remove empty lines.

2 changes: 2 additions & 0 deletions HLTrigger/Configuration/python/HLT_75e33_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@
fragment.load("HLTrigger/Configuration/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi")
fragment.load("HLTrigger/Configuration/HLT_75e33/paths/HLT_IsoMu20_eta2p1_LooseDeepTauPFTauHPS27_eta2p1_CrossL1_cfi")
fragment.load("HLTrigger/Configuration/HLT_75e33/paths/HLT_IsoMu24_FromL1TkMuon_cfi")
fragment.load("HLTrigger/Configuration/HLT_75e33/paths/HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1_cfi")
fragment.load("HLTrigger/Configuration/HLT_75e33/paths/HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_FromL1TkMuon_cfi")
fragment.load("HLTrigger/Configuration/HLT_75e33/paths/HLT_Mu37_Mu27_FromL1TkMuon_cfi")
fragment.load("HLTrigger/Configuration/HLT_75e33/paths/HLT_Mu50_FromL1TkMuon_cfi")
Expand Down Expand Up @@ -360,6 +361,7 @@
fragment.HLT_DoubleMediumDeepTauPFTauHPS35_eta2p1,
fragment.HLT_IsoMu20_eta2p1_LooseDeepTauPFTauHPS27_eta2p1_CrossL1,
fragment.HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1,
fragment.HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1,
### Removed temporarily until final decision on L1T tau Phase-2
#fragment.L1T_DoubleNNTau52,
#fragment.L1T_SingleNNTau150,
Expand Down
3 changes: 2 additions & 1 deletion HLTrigger/Configuration/python/HLT_75e33_timing_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@
fragment.load("HLTrigger/Configuration/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi")
fragment.load("HLTrigger/Configuration/HLT_75e33/paths/HLT_IsoMu20_eta2p1_LooseDeepTauPFTauHPS27_eta2p1_CrossL1_cfi")
fragment.load("HLTrigger/Configuration/HLT_75e33/paths/HLT_IsoMu24_FromL1TkMuon_cfi")
fragment.load("HLTrigger/Configuration/HLT_75e33/paths/HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1_cfi")
fragment.load("HLTrigger/Configuration/HLT_75e33/paths/HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_FromL1TkMuon_cfi")
fragment.load("HLTrigger/Configuration/HLT_75e33/paths/HLT_Mu37_Mu27_FromL1TkMuon_cfi")
fragment.load("HLTrigger/Configuration/HLT_75e33/paths/HLT_Mu50_FromL1TkMuon_cfi")
Expand Down Expand Up @@ -341,7 +342,7 @@
fragment.HLT_DoubleMediumChargedIsoPFTauHPS40_eta2p1,
fragment.HLT_DoubleMediumDeepTauPFTauHPS35_eta2p1,
fragment.HLT_IsoMu20_eta2p1_LooseDeepTauPFTauHPS27_eta2p1_CrossL1,

fragment.HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1,
### Removed temporarily until final decision on L1T tau Phase-2
#fragment.L1T_DoubleNNTau52,
#fragment.L1T_SingleNNTau150,
Expand Down