Update clang easyblock for newer LLVM/Clang versions #3754
Conversation
| self.runtimes_cmake_args['LIBOMPTARGET_DEVICE_ARCHITECTURES'] = '%s' % '|'.join(gpu_archs) | ||
| self.runtimes_cmake_args['LIBOMPTARGET_DEVICE_ARCHITECTURES'] = '%s' % ';'.join(gpu_archs) |
There was a problem hiding this comment.
This actively breaks runtime builds, since ; is interpreted as the end of a CMake argument. We ran into this when fixing the LLVM EasyBlock for offloading, see:
There was a problem hiding this comment.
Thanks, I haven't seen this is a argument to an argument. semicolons are list separators and we pass a list of key=value to a variable. So using the semicolon here makes it split the list inside a value instead of after it.
I haven't found any doc to support the use of the pipe but seems to be ok. But we can also just set this as a regular CMake variable and it will be passed through automatically
There was a problem hiding this comment.
Yeah... the pipe isn't really documented, but there are a few places where LLVM does this internally. That's where I found this.
|
Closing in favor of updating the LLVM easyblock |
(created using
eb --new-pr)Especially the OpenMP target/offloading handling has changed significantly in 19 and again in 20. Update the code and unify some parts with the LLVM easyblock to avoid code duplication and drift