Skip to content

Conversation

@adamscott
Copy link
Member

The current (and newly added #107973) appleembedded.permission.AUDIO_RECORD don't follow the current permission name framework of "<ACTION>_<SUBJECT>".

This PR rectifies this issue. It warns the user when AUDIO_RECORD is used, but grants the request nonetheless. Though, to keep compatibility with 4.5 users, when requesting granted permissions, both AUDIO_RECORD and RECORD_AUDIO are given for the same permission. In a future version, we could remove the AUDIO_RECORD one.

Capture d’écran, le 2025-10-14 à 21 17 59

The AUDIO_RECORD mention in the docs stick out from the rest.

@adamscott
Copy link
Member Author

adamscott commented Oct 15, 2025

cc. @migueldeicaza @paddy-exe

@adamscott adamscott force-pushed the fix-weird-permission-name branch from 7bd1acb to 4d3c428 Compare October 15, 2025 11:03
@akien-mga
Copy link
Member

To be honest I find this a bit pointless to rename. I get that this doesn't exactly follow the convention we've used for other settings, and notably the equivalent macOS one, but since this shipped already in 4.5 I don't think it's worth it to make this change and deprecate the previous name.

Especially now that we're in feature freeze for 4.6, so this would be in scope for 4.7 at the earliest, and having a compatibility matrix that's like:

  • Before 4.5: no feature
  • 4.5 and 4.6: AUDIO_RECORD
  • 4.7: RECORD_AUDIO, or a warning
    doesn't sound great to me.

I don't oppose this too strongly though, and bruvzg already approved as area maintainer, but those are my 2 cents. Nobody complained about this so I don't think it's something we should change.

@akien-mga akien-mga modified the milestones: 4.6, 4.7 Dec 18, 2025
@bruvzg
Copy link
Member

bruvzg commented Dec 18, 2025

I'm in favor of renaming, since it's more consistent, but I won't insist. Keeping it for 4.7 should be fine.

@akien-mga
Copy link
Member

Maybe a compromise to deprecate AUDIO_RECORD but not print an obnoxious warning would be ok. And we would keep the deprecated alias for the rest of the 4.x lifetime, so users who have been using it in 4.5/4.6 don't need to change their code for a cosmetic rename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants