-
-
Notifications
You must be signed in to change notification settings - Fork 23.9k
Rename appleembedded.permission.{AUDIO_RECORD->RECORD_AUDIO}
#111665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7bd1acb to
4d3c428
Compare
|
To be honest I find this a bit pointless to rename. I get that this doesn't exactly follow the convention we've used for other settings, and notably the equivalent macOS one, but since this shipped already in 4.5 I don't think it's worth it to make this change and deprecate the previous name. Especially now that we're in feature freeze for 4.6, so this would be in scope for 4.7 at the earliest, and having a compatibility matrix that's like:
I don't oppose this too strongly though, and bruvzg already approved as area maintainer, but those are my 2 cents. Nobody complained about this so I don't think it's something we should change. |
|
I'm in favor of renaming, since it's more consistent, but I won't insist. Keeping it for 4.7 should be fine. |
|
Maybe a compromise to deprecate |
The current (and newly added #107973)
appleembedded.permission.AUDIO_RECORDdon't follow the current permission name framework of "<ACTION>_<SUBJECT>".This PR rectifies this issue. It warns the user when
AUDIO_RECORDis used, but grants the request nonetheless. Though, to keep compatibility with 4.5 users, when requesting granted permissions, bothAUDIO_RECORDandRECORD_AUDIOare given for the same permission. In a future version, we could remove theAUDIO_RECORDone.The
AUDIO_RECORDmention in the docs stick out from the rest.