Skip to content

Rename appleembedded.permission.{AUDIO_RECORD->RECORD_AUDIO} #111665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamscott wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −2
Open

Rename appleembedded.permission.{AUDIO_RECORD->RECORD_AUDIO} #111665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/classes/OS.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,7 +801,7 @@
- [code]OS.request_permission("android.permission.READ_EXTERNAL_STORAGE")[/code]
- [code]OS.request_permission("android.permission.POST_NOTIFICATIONS")[/code]
- [code]OS.request_permission("macos.permission.RECORD_SCREEN")[/code]
- [code]OS.request_permission("appleembedded.permission.AUDIO_RECORD")[/code]
- [code]OS.request_permission("appleembedded.permission.RECORD_AUDIO")[/code]
[b]Note:[/b] On Android, permission must be checked during export.
[b]Note:[/b] This method is implemented on Android, macOS, and visionOS platforms.
</description>
Expand Down
13 changes: 12 additions & 1 deletion drivers/apple_embedded/os_apple_embedded.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,15 @@ Rect2 fit_keep_aspect_covered(const Vector2 &p_container, const Vector2 &p_rect)
}

bool OS_AppleEmbedded::request_permission(const String &p_name) {
if (p_name == "appleembedded.permission.AUDIO_RECORD") {
String permission_name = p_name;
#ifndef DISABLE_DEPRECATED
if (permission_name == "appleembedded.permission.AUDIO_RECORD") {
WARN_PRINT(R"*(OS.request_permission("appleembedded.permission.AUDIO_RECORD") is deprecated. Please use "appleembedded.permission.RECORD_AUDIO" instead.)*");
permission_name = "appleembedded.permission.RECORD_AUDIO";
}
#endif

if (permission_name == "appleembedded.permission.RECORD_AUDIO") {
if (@available(iOS 17.0, *)) {
AVAudioApplicationRecordPermission permission = [AVAudioApplication sharedInstance].recordPermission;
if (permission == AVAudioApplicationRecordPermissionGranted) {
Expand All @@ -761,7 +769,10 @@ Rect2 fit_keep_aspect_covered(const Vector2 &p_container, const Vector2 &p_rect)

if (@available(iOS 17.0, *)) {
if ([AVAudioApplication sharedInstance].recordPermission == AVAudioApplicationRecordPermissionGranted) {
ret.push_back("appleembedded.permission.RECORD_AUDIO");
#ifndef DISABLE_DEPRECATED
ret.push_back("appleembedded.permission.AUDIO_RECORD");
#endif
}
}
return ret;
Expand Down