Re-introduce call to makeDeltaAst to fix #4731
#4814
Merged
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aster89
commented
Jan 27, 2026
Aster89
commented
Jan 27, 2026
fendor
reviewed
Jan 30, 2026
Aster89
changed the title
makeDeltaAst to fix #4731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, I want to see how all tests go, just in case this is indeed the fix we need.
At Aster89@b4ce284 you can see my current investigation.
Fwiw, I've printed
pswithout and with callingmakeDeltaAst(i.e. before and after my fix respectively), and this is the diff I see.Maybe somebody can give a look at it?
Closes #4731