Temporary enable TRITON_SUPPRESS_GCC_HOST_CODE_DEPRECATION_WARNINGS by default
#4475
Conversation
python/triton/runtime/build.py
Outdated
| @@ -96,7 +96,7 @@ def _build(name: str, src: str, srcdir: str, library_dirs: list[str], include_di | |||
| else: | |||
| if os.name != "nt": | |||
| extra_compile_args += ["--std=c++17"] | |||
| if os.environ.get("TRITON_SUPPRESS_GCC_HOST_CODE_DEPRECATION_WARNINGS"): | |||
| if os.environ.get("TRITON_SUPPRESS_GCC_HOST_CODE_DEPRECATION_WARNINGS", "True"): | |||
There was a problem hiding this comment.
This is true for any non empty value
There was a problem hiding this comment.
I remade it, but didn't do complex parsing
|
If it is enabled by default, is there any issues with passing |
|
@pbchekin presumably that would show up in CI... Maybe it is worth revisiting the system library include, though -- see intel/llvm#18449. |
Let's see: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/15568829257 |
|
I tested locally with and this PR worked. The windows run is a little more iffy but I think it got stuck in one of the normal places, I don't see any issues compiling there. I re-started it but I think we can go ahead with this PR without waiting for it to finish. |
CI: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/15568618894