Skip to content

Conversation

@anmyachev
Copy link
Contributor

@anmyachev anmyachev commented Jun 10, 2025

if os.name != "nt":
extra_compile_args += ["--std=c++17"]
if os.environ.get("TRITON_SUPPRESS_GCC_HOST_CODE_DEPRECATION_WARNINGS"):
if os.environ.get("TRITON_SUPPRESS_GCC_HOST_CODE_DEPRECATION_WARNINGS", "True"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true for any non empty value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remade it, but didn't do complex parsing

@pbchekin
Copy link
Contributor

If it is enabled by default, is there any issues with passing -Wno-deprecated-declarations to non GCC compilers (for example, on Windows)?

@alexbaden
Copy link
Contributor

@pbchekin presumably that would show up in CI...

Maybe it is worth revisiting the system library include, though -- see intel/llvm#18449.

@anmyachev
Copy link
Contributor Author

If it is enabled by default, is there any issues with passing -Wno-deprecated-declarations to non GCC compilers (for example, on Windows)?

Let's see: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/15568829257

@alexbaden alexbaden marked this pull request as ready for review June 11, 2025 01:36
@alexbaden
Copy link
Contributor

I tested locally with

CXX=g++ TRITON_ALWAYS_COMPILE=1 python python/tutorials/01-vector-add.py

and this PR worked. The windows run is a little more iffy but I think it got stuck in one of the normal places, I don't see any issues compiling there. I re-started it but I think we can go ahead with this PR without waiting for it to finish.

@alexbaden alexbaden merged commit 0c02681 into main Jun 11, 2025
16 of 19 checks passed
@alexbaden alexbaden deleted the anmyachev-patch-1 branch June 11, 2025 02:05
alexbaden pushed a commit that referenced this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants