[mxfp] Reland remove col-major assert for mx weight #5285
Merged
+172
−229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdziurdz
force-pushed
the
dev/wdziurdz/test-matmul-6
branch
from
b115046 to
d6e3e58
Compare
|
Looks like triton-kernels tests hang. |
januszjah
reviewed
Oct 13, 2025
|
Converted to draft, as it needs more work before it will be ready for review again. |
|
The PR passed, but it's only due to lowering the num_procs of pytest for kernel tests - not a solution, only experiment, that confirms that the hang is due to traffic on the device. When process hanged, the callstack on CI machnie showed hang during mem copy: There is internal issue on the Agama reported for same type of hang and there is potential hotfix that might help here - need to check it with @kwasd . |
Follow-up triton-lang/triton#7795 Now transposed weight is supported, remove unnecessary assertion that mx weight should be col-major <!--- The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> # New contributor declaration - [x] I am not making a trivial change, such as fixing a typo in a comment. - [x] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [x] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [ ] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [x] This PR does not need a test because `FILL THIS IN`. - Select one of the following. - [x] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.) --------- Co-authored-by: Thomas Raoux <[email protected]>
whitneywhtsang
force-pushed
the
dev/wdziurdz/test-matmul-6
branch
from
c093a9c to
c8d7574
Compare
|
Rebased the PR, as it is a relanding PR that we don't want to squash and merge. |
Signed-off-by: Witold Dziurdz <[email protected]>
whitneywhtsang
force-pushed
the
dev/wdziurdz/test-matmul-6
branch
from
c8d7574 to
352b348
Compare
whitneywhtsang
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5269