[Driver][SYCL] Pass as system headers for external SYCL host compilation #18449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lation The use of `-fsycl-host-compiler=arg` allows a user to specify a 3rd party compiler to perform host compilation when using `-fsycl`. The compilation will also include the SYCL specific headers. Pass in these headers as system headers with `-isystem` so they are treated as system headers as opposed to user headers. Signed-off-by: Michael D Toguchi <[email protected]>
hchilama
approved these changes
May 13, 2025
tahonermann
reviewed
May 13, 2025
Comment on lines
5297
to
5301
| HostCompileArgs.push_back(IsMSVCHostCompiler ? "-I" : "-isystem"); | ||
| HostCompileArgs.push_back(TCArgs.MakeArgString(SYCLDir)); | ||
| HostCompileArgs.push_back("-I"); | ||
| HostCompileArgs.push_back(IsMSVCHostCompiler ? "-I" : "-isystem"); | ||
| HostCompileArgs.push_back(TCArgs.MakeArgString(STLWrappersDir)); | ||
| HostCompileArgs.push_back("-I"); | ||
| HostCompileArgs.push_back(IsMSVCHostCompiler ? "-I" : "-isystem"); |
There was a problem hiding this comment.
Can we use /external:I for MSVC?
There was a problem hiding this comment.
Looks like we can. I double checked our release support matrix, and the releases we support doesn't require the additional /external:experimental flag.
tahonermann
approved these changes
May 14, 2025
srividya-sundaram
approved these changes
May 14, 2025
|
Failure known with issue here: #18463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
-fsycl-host-compiler=argallows a user to specify a 3rd party compiler to perform host compilation when using-fsycl. The compilation will also include the SYCL specific headers. Pass in these headers as system headers with-isystemso they are treated as system headers as opposed to user headers.