[SYCL] Fix function attribute merging on template declarations #21158
+83
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20419 implements attribute merging for
add_ir_attributes_*attributes. This commit fixes an issue that occurs when merging attributes on function template declarations.Attribute merging is deferred until template instantiation if an attribute contains dependent expressions. Previously, we only checked if the existing attribute was dependent but not if the new attribute was dependent. This would cause the merge to fail but the new attribute would still be dropped from the AST. This commit ensures both attributes are checked and new dependent attributes do not disappear.