tests(library/math): stubs complete coverage for greatestCommonDivisor
#532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjacobgordon
force-pushed
the
tests(library/math)--stubs-coverage-for-`greatestCommonDivisor`
branch
from
671a6fb to
3155676
Compare
bjacobgordon
added a commit
to bjacobgordon/shark-ui
that referenced
this pull request
Jul 16, 2025
…stCommonDivisor` (nod-ai#533) - establishes a few key precedents for testing functional units: - differentiate between sad and happy paths (in that order) - for sad paths, make it apparent as to: - which failures the unit is expected to define (errors, error messages, etc.) - which it's expected to delegate (dependence on other units) - end with the most obvious (and least interesting) best-case scenario, i.e. "gets the correct answer" - facilitates nod-ai#532
bjacobgordon
force-pushed
the
tests(library/math)--stubs-coverage-for-`greatestCommonDivisor`
branch
3 times, most recently
from
3a42c6f to
2c051aa
Compare
- it really means "the term used to refer to the inputs in this specific context" - i.e. if it's a mathematical operation, then the preferred term would be "operands"
…greatestCommonDivisor`
…greatestCommonDivisor`
bjacobgordon
force-pushed
the
tests(library/math)--stubs-coverage-for-`greatestCommonDivisor`
branch
from
2c051aa to
bf18579
Compare
bjacobgordon
deleted the
tests(library/math)--stubs-coverage-for-`greatestCommonDivisor`
branch
This was referenced Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
greatestCommonDivisor#533