Skip to content

tests(library/math): applies template for functional suite to greatestCommonDivisor #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2025
Merged

tests(library/math): applies template for functional suite to greatestCommonDivisor #533

merged 3 commits into from
Jul 16, 2025

Conversation

bjacobgordon
Copy link
Collaborator

  • establishes a few key precedents for testing functional units:
    • differentiate between sad and happy paths (in that order)
    • for sad paths, make it apparent as to:
      • which failures the unit is expected to define (errors, error messages, etc.)
      • which it's expected to delegate (dependence on other units)
    • end with the most obvious (and least interesting) best-case scenario, i.e. "gets the correct answer"
  • facilitates tests(library/math): stubs complete coverage for greatestCommonDivisor #532

@bjacobgordon bjacobgordon self-assigned this Jul 16, 2025
@github-actions github-actions bot added the tests label Jul 16, 2025
@bjacobgordon bjacobgordon merged commit 312fe20 into nod-ai:integration Jul 16, 2025
3 checks passed
@bjacobgordon bjacobgordon deleted the tests-library-math-applies-template-for-functional-unit-suite branch July 16, 2025 19:17
This was referenced Jul 16, 2025
Open
Merged
bjacobgordon added a commit that referenced this pull request Jul 16, 2025
@bjacobgordon
tests(library/math): stubs complete coverage for `greatestCommonDivis…
759e279 
…or` (#532)

- polishes a documentation introduced in #533 
    - "inputs" is an umbrella term that really means "the term used to refer to the inputs in this specific context"
    - i.e. if it's a mathematical operation, then the preferred term would be "operands"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bjacobgordon bjacobgordon

Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bjacobgordon