Upgrade to protobuf 6.31.1 #3275
Conversation
gongsu832
force-pushed
the
upgrade_protobuf_v6.31.1
branch
2 times, most recently
from
5b23648 to
22ac878
Compare
|
OK MacOS CI build is fixed. The requirements.txt still had the old version of protobuf specified, which overrode the new version. The PR is ready to be merged. |
rules_rust 0.56.0 with s390x support we managed to upstream.
Some caveats apply:
- bazel related toolchain support on ppc64le is even worse
than that on s390x so this PR will not work on ppc64le.
As a result, we will have to retire our ppc64le Jenkins CI
after this PR (we can resurrect it once the bazel toolchain
on ppc64le catches up). ppc64le Jenkins CI is not required
for merging
- onnx cmake build file needs to be patched to add some missing
dependencies on abseil, which should eventually be upstreamed
Signed-off-by: Gong Su <[email protected]>
Signed-off-by: Gong Su <[email protected]>
Signed-off-by: Gong Su <[email protected]>
Signed-off-by: Gong Su <[email protected]>
Signed-off-by: Gong Su <[email protected]>
Signed-off-by: Gong Su <[email protected]>
Signed-off-by: Gong Su <[email protected]>
Signed-off-by: Gong Su <[email protected]>
Signed-off-by: Gong Su <[email protected]>
- subdivide jobs so mlir cache can be posted early Signed-off-by: Gong Su <[email protected]>
Signed-off-by: Gong Su <[email protected]>
Signed-off-by: Gong Su <[email protected]>
Signed-off-by: Gong Su <[email protected]>
onnx doesn't get installed then reinstalled Signed-off-by: Gong Su <[email protected]>
gongsu832
force-pushed
the
upgrade_protobuf_v6.31.1
branch
from
22ac878 to
046183c
Compare
|
Do we need to update the document(such as BuildOnLinuxOSX.md) accordingly? |
There is really nothing changed in terms of building onnx-mlir itself. Most of the changes are for building protobuf with C/C++ backend on s390x. We can certainly describe what's need to be done in BuildOnLinuxOSX.md but unless you are a developer you probably don't care about that. This is also the reason we typically recommend people to use the prebuilt docker image instead of trying to do all these dirty hack themselves. |
|
@gongsu832 I am running some tests based off this pr especially on the abseil dependency part. I will update the results here with my experiment. Sorry for the delay caught up with a few urgent issues. Will try to post the results and findings by next week. |
Upgrade to protobuf 6.31.1, which is the 1st version that uses rules_rust 0.56.0 with s390x support we managed to upstream. Some caveats apply:
bazel related toolchain support on ppc64le is even worse than that on s390x so this PR will not work on ppc64le. As a result, we will have to retire our ppc64le Jenkins CI after this PR (we can resurrect it once the bazel toolchain on ppc64le catches up). ppc64le Jenkins CI is not required for merging
onnx cmake build file needs to be patched to add some missing dependencies on abseil, which should eventually be upstreamed