Prevent error when workers config not found, throw warning instead

[Wabri]

Related: https://progress.opensuse.org/issues/181409

This is still a work in progress, the purpose of this is to replace the error with a warning since the instance even without the definition of the configuration is working.

[Martchus]

I'm afraid you'll need to restructure the corresponding test:

    #   Failed test 'error logged'
    #   at t/24-worker-settings.t line 130.
    #     Structures begin differing at:
    #          $got->[0] = Does not exist
    #     $expected->[0] = 'No config file found.'
    # []
    # Looks like you failed 1 test of 2.

[Martchus]

And how does this actually look like as a whole (together with the other startup log messages)? I'm just wondering because you're effectively moving the place where we log this and therefore possibly change the order of startup log messages.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@2d67834). Learn more about missing BASE report.
Report is 20 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #6568   +/-   ##
=========================================
  Coverage          ?   99.10%           
=========================================
  Files             ?      399           
  Lines             ?    40630           
  Branches          ?        0           
=========================================
  Hits              ?    40265           
  Misses            ?      365           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Wabri]

@Martchus finally find the way to spin a single-instance container with local changes and this is the result:

+ su _openqa-worker -c '/opt/openqa/script/worker --instance 1'
+ [[ -n '' ]]
+ wait
[INFO] workers.ini not found, using default settings
[info] worker 1:
 - config file:
 - name used to register:            1e039ebbb480
 - worker address (WORKER_HOSTNAME): localhost
 - isotovideo version:               44
 - websocket API version:            1
 - web UI hosts:                     localhost
 - class:                            ?
 - no cleanup:                       no
 - pool directory:                   /var/lib/openqa/pool/1
[info] Project dir for host localhost is /var/lib/openqa/share
[info] Registering with openQA localhost

The log info is shown as expected!

I'm preparing a new pr with a new docker file to spin the single instance container with local changes.

[Martchus]

The inconsistent capitalization of the info messages is not nice but I guess it is acceptable. (I guess I would have made it so it would still log everything were it was logged before and just make the parameter passing between the function calls a bit more involved. I guess your simple approach is ok, too.)