Fully Cover OpenQA::WebAPI::Plugin::MemoryLimit

[Wabri]

Reference: https://progress.opensuse.org/issues/178948

[Martchus]

I'd avoid the use of "assignation" in this context as "assignment" is much more conventional here. The commit message should probably just be "Use signatures in memory limit plugin" anyway, though.

[Martchus]

This code is still not setting max_rss_limit to something > 0 and even if it would the relevant code wouldn't be executed as the test needed to run the event loop.

[Wabri]

Mh you are right, but I was sure to have it at one point 😕

[Martchus]

Your new version still doesn't run the event loop. Probably you'll just have to start it and the code under test will then stop it on its own. You probably want to make the hard-coded timer interval configurable so the test doesn't waste 5 seconds.

[Martchus]

It would also make sense to check whether Worker exceeded RSS limit is printed.

[Wabri]

Yas, you are right... I've try to test it, but I guess I miss some knowledge on https://docs.mojolicious.org/Mojo/IOLoop

[Martchus]

Well, you've already found the documentation :-)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.23%. Comparing base (b5ecb3e) to head (6068cc9).
⚠️ Report is 33 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6693   +/-   ##
=======================================
  Coverage   99.22%   99.23%           
=======================================
  Files         398      399    +1     
  Lines       40888    40895    +7     
=======================================
+ Hits        40571    40581   +10     
+ Misses        317      314    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Martchus]

Suggested change

	Mojo::IOLoop->start;

I guess you can set the conditions so the code under test will stop the loop automatically. And you should make the interval configurable to avoid wasting 5 seconds until that would happen.