Skip to content

Fully Cover OpenQA::WebAPI::Plugin::MemoryLimit #6693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+15 −4
Open

Fully Cover OpenQA::WebAPI::Plugin::MemoryLimit #6693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a2c445
Replace argument assignation with signatures on MemoryLimit
Wabri Sep 2, 2025
6068cc9
t: run at least once Memorylimit register with max_rss_limit > 0
Wabri Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lib/OpenQA/WebAPI/Plugin/MemoryLimit.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,13 @@
# SPDX-License-Identifier: GPL-2.0-or-later

package OpenQA::WebAPI::Plugin::MemoryLimit;
use Mojo::Base 'Mojolicious::Plugin';
use Mojo::Base 'Mojolicious::Plugin', -signatures;

use BSD::Resource 'getrusage';
use Mojo::IOLoop;

# Stop prefork workers gracefully once they reach a certain size
sub register {
my ($self, $app) = @_;

sub register ($self, $app, $conf) {
my $max = $app->config->{global}{max_rss_limit};
return unless $max && $max > 0;

Expand Down
13 changes: 13 additions & 0 deletions t/api/14-plugin_memory_limit.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Copyright SUSE LLC
# SPDX-License-Identifier: GPL-2.0-or-later

use Test::Most;
use Mojolicious;

use_ok('OpenQA::WebAPI::Plugin::MemoryLimit');

my $app = Mojolicious->new;
$app->config->{global}{max_rss_limit} = 42;
OpenQA::WebAPI::Plugin::MemoryLimit->register($app, undef);

Copy link
Contributor

@Martchus Martchus Sep 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Mojo::IOLoop->start;

I guess you can set the conditions so the code under test will stop the loop automatically. And you should make the interval configurable to avoid wasting 5 seconds until that would happen.

done_testing;