Skip to content

(#2174645) Make sure journalctl --flush does not hang#366

Merged
jamacku merged 3 commits intoredhat-plumbers:rhel-8.8.0from
dtardon:bz2174645-journal-flush-8.8
Mar 13, 2023
Merged

(#2174645) Make sure journalctl --flush does not hang#366
jamacku merged 3 commits intoredhat-plumbers:rhel-8.8.0from
dtardon:bz2174645-journal-flush-8.8

Conversation

@dtardon
Copy link
Member

@dtardon dtardon commented Mar 13, 2023

This is not a change I'm proud of, but it fixes the regression and it is good enough for the original use case...

Resolves: #2174645

dtardon added 3 commits March 13, 2023 15:18
`journalctl --flush` waits on that file, so we must create if even if
nothing has really happened.

RHEL-only

Resolves: #2174645
No functional change, just refactoring.

RHEL-only

Related: #2174645
`journalctl --relinquish-var` waits on that file, so we must create if
even if nothing has really happened.

RHEL-only

Related: #2174645
@systemd-rhel-bot systemd-rhel-bot added the pr/needs-review Formerly needs-review label Mar 13, 2023
@systemd-rhel-bot systemd-rhel-bot changed the title Make sure journalctl --flush does not hang (#2174645) Make sure journalctl --flush does not hang Mar 13, 2023
@mergify mergify bot added the pr/needs-ci Formerly needs-ci label Mar 13, 2023
@jamacku jamacku added this to the RHEL-8.8 milestone Mar 13, 2023
@msekletar
Copy link
Member

CI failure seems unrelated (although we should really work on better reliability of logind test case).

Copy link
Member

@msekletar msekletar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@systemd-rhel-bot systemd-rhel-bot removed the pr/needs-review Formerly needs-review label Mar 13, 2023
@mergify mergify bot removed the pr/needs-ci Formerly needs-ci label Mar 13, 2023
@systemd-rhel-bot systemd-rhel-bot removed the tracker/unapproved Formerly needs-acks label Mar 13, 2023
@jamacku jamacku merged commit 980add7 into redhat-plumbers:rhel-8.8.0 Mar 13, 2023
@dtardon dtardon deleted the bz2174645-journal-flush-8.8 branch March 14, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants