Skip to content

Test updated schema for adding Python 3.13 support. #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 2, 2025

Conversation

FanwangM
Copy link
Contributor

@FanwangM FanwangM commented May 31, 2025

Summary by Sourcery

Add Python 3.13 support by updating CI test matrix and project metadata

Enhancements:

  • Add Python 3.13 to the project's classifiers in pyproject.toml

CI:

  • Include Python 3.13 in the GitHub Actions pytest matrix and add Python 3.10 and 3.11 to the strategy
  • Restrict macOS and Windows runs to only Python 3.9 and 3.13

@FanwangM FanwangM requested a review from Copilot May 31, 2025 21:33
Copy link
Contributor

sourcery-ai bot commented May 31, 2025

Reviewer's Guide

This PR extends CI testing to Python 3.13 by updating the GitHub Actions matrix with new versions and exclusions, and updates project metadata to declare Python 3.13 support.

File-Level Changes

Change Details Files
Extend CI workflow matrix to include Python 3.13 with targeted exclusions
  • Expanded python-version matrix from 3.9/3.12 to 3.9–3.13
  • Added exclude entries to limit MacOS and Windows tests to Python 3.9 and 3.13 only
.github/workflows/pytest.yaml
Declare Python 3.13 support in package classifiers
  • Inserted "Programming Language :: Python :: 3.13" into the classifiers list
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

deepsource-io bot commented May 31, 2025

Here's the code health analysis summary for commits ab01d84..ce9a871. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for Python 3.13 by updating project metadata and CI configuration.

  • Added Python 3.13 to the list of supported classifiers in pyproject.toml.
  • Expanded the GitHub Actions pytest matrix to include 3.10, 3.11, and 3.13, and excluded intermediate versions on macOS and Windows.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Added "Programming Language :: Python :: 3.13" classifier.
.github/workflows/pytest.yaml Expanded python-version matrix and added exclusions for non-Linux OS.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @FanwangM - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@FanwangM FanwangM requested a review from Copilot May 31, 2025 21:40
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for Python 3.13 by updating the metadata in pyproject.toml and extending the CI test matrix in the GitHub Actions workflow.

  • Updates classifiers in pyproject.toml to include Python 3.13.
  • Modifies the pytest GitHub Actions workflow to run tests on Python 3.13 on Ubuntu and restrict macOS and Windows runs to only Python 3.9 and 3.13.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pyproject.toml Added Python 3.13 classifier to the list of supported versions.
.github/workflows/pytest.yaml Extended the matrix to include Python 3.13 and updated OS exclusions.

Copy link
Member

@tovrstra tovrstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe exclusion need to be listed individually, e.g. as follows:

exclude:
  - os: macos-latest
    python-version: '3.10'
  - os: macos-latest
    python-version: '3.11'
...

It's a bit tedious, but AFAIK there is no other way. The only alternative I can think of is to define the matrix with Linux only and then to use include: to add a few more OS-Python combinations

Copy link
Member

@tovrstra tovrstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems to have worked

@FanwangM FanwangM merged commit 0d7d58b into theochem:main Jun 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants