-
Notifications
You must be signed in to change notification settings - Fork 48
Test updated schema for adding Python 3.13 support. #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR extends CI testing to Python 3.13 by updating the GitHub Actions matrix with new versions and exclusions, and updates project metadata to declare Python 3.13 support. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for Python 3.13 by updating project metadata and CI configuration.
- Added Python 3.13 to the list of supported classifiers in
pyproject.toml
. - Expanded the GitHub Actions pytest matrix to include 3.10, 3.11, and 3.13, and excluded intermediate versions on macOS and Windows.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
pyproject.toml | Added "Programming Language :: Python :: 3.13" classifier. |
.github/workflows/pytest.yaml | Expanded python-version matrix and added exclusions for non-Linux OS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @FanwangM - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds support for Python 3.13 by updating the metadata in pyproject.toml and extending the CI test matrix in the GitHub Actions workflow.
- Updates classifiers in pyproject.toml to include Python 3.13.
- Modifies the pytest GitHub Actions workflow to run tests on Python 3.13 on Ubuntu and restrict macOS and Windows runs to only Python 3.9 and 3.13.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
pyproject.toml | Added Python 3.13 classifier to the list of supported versions. |
.github/workflows/pytest.yaml | Extended the matrix to include Python 3.13 and updated OS exclusions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe exclusion need to be listed individually, e.g. as follows:
exclude:
- os: macos-latest
python-version: '3.10'
- os: macos-latest
python-version: '3.11'
...
It's a bit tedious, but AFAIK there is no other way. The only alternative I can think of is to define the matrix with Linux only and then to use include:
to add a few more OS-Python combinations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, seems to have worked
Summary by Sourcery
Add Python 3.13 support by updating CI test matrix and project metadata
Enhancements:
CI: