Fix memory leak in py_uwsgi_spooler_pids #2703
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henyu6
force-pushed
the
fix-leak-spooler-pids
branch
from
ea40863 to
30470ba
Compare
methane
approved these changes
Jul 2, 2025
luchr
reviewed
Aug 4, 2025
plugins/python/uwsgi_pymodule.c
Outdated
| struct uwsgi_spooler *uspool = uwsgi.spoolers; | ||
| while (uspool) { | ||
| PyList_Append(ret, PyInt_FromLong(uspool->pid)); | ||
| PyObject *spool_pid = PyInt_FromLong(uspool->pid) |
Contributor
There was a problem hiding this comment.
There is a semicolon ";" missing at the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we call PyInt_FromLong, the reference count is increased and PyList_Append increasing the reference count again because when using PyList_Append, the reference count is incremented and not taken.
The change made is to set the result of PyInt_FromLong, append it to the list, then decrement the reference count.