Skip to content

Fix memory leak in py_uwsgi_spooler_pids #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henyu6 wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −1
Open

Fix memory leak in py_uwsgi_spooler_pids #2703

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30470ba
fix mem leak in get spooler pids
henyu6 Jan 30, 2025
728d9a6
add missing semi colon
henyu6 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugins/python/uwsgi_pymodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2278,7 +2278,9 @@ PyObject *py_uwsgi_spooler_pids(PyObject * self, PyObject * args) {
PyObject *ret = PyList_New(0);
struct uwsgi_spooler *uspool = uwsgi.spoolers;
while (uspool) {
PyList_Append(ret, PyInt_FromLong(uspool->pid));
PyObject *spool_pid = PyInt_FromLong(uspool->pid)
Copy link
Contributor

@luchr luchr Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a semicolon ";" missing at the end.

PyList_Append(ret, spool_pid);
Py_DECREF(spool_pid);
uspool = uspool->next;
}
return ret;
Expand Down