Skip to content

Fixing issues in #721 #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

gregoriopellegrino
Copy link
Collaborator

No description provided.

Copy link
Member

@mattgarrish mattgarrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.

Explaining the xpaths we'd need to discuss as it would take a lot of work to do. We did something similar with the publication manifest processing using details elements.

@gregoriopellegrino
Copy link
Collaborator Author

Explaining the functions of XPATH m seems a bit of a stretch, can't we refer back to the specifications?

https://www.w3.org/TR/xpath-10/#corelib

@mattgarrish
Copy link
Member

I don't think we even need to go that far. If you don't know what xpath functions do you can look those up. I was just thinking about explaining what some of the complex xpaths are capturing, like the closest lang declaration or what the ones that use refines are looking for. I can see some of those being a challenge to follow. The understanding the variables sections only give you a very high-level description of what is captured in these cases.

@mattgarrish
Copy link
Member

But it's also time-consuming to do and I don't know that we have the time right now to do it with everything else we want to work on.

Copy link
Collaborator

@rickj rickj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by my team. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants