new feature: Energy-Profile #1652

TihKay · 2017-09-28T09:03:26Z

Hi,
I would offer you a new useful feature for the "MissionPlanner".
This feature involves that the user can create his own energy-profile of his multicopter.

For now it exist two individual input-tables for some current-tilt-angle-values and some velocity-tilt-angle-values. From this sample points will be interpolate all the others required values.
The config menu of the energy-profile has got an export and import function and its deactivated on start.

If the energy-profile is active, the user can read the probable average energy consumption and probable average flight time between two waypoints or the entire route in the "FlightPlanner-View". For the time being, only the command "WAYPOINT" and "LOITER_TIME" are supported.

Soon:

an automatically function for analyse the values from logfile to determine the sample points
a helpful setup for the user, that he can perform a "Benchmark-Flight" for better values in logfiles

I hope I could arouse interest for this feature.

Updating new Branch

… consumption feature. Energy consumption is shown as mAh (milliampere per hour)

… parameters for the energyconsumption of the multicopter (will be changed soon)

todo: find appopriate function for I(angle) and v(angle)

For now linear approximation from -90 to 0 degree and 0 to 90 degree. 0 degree is the base energy consumption (hovering for example)

ToDo: -Polynom for I should be of grade 2 oder 3 -v could be relatively linear -linechart to see parameters in diagram (system.windows.forms.datavisualization)

function nearly complete

…r velocity in km/h; still the time was handled as seconds)...the distance is also given in meters, not kilometers

Signed-off-by: Thomas Dietrich <[email protected]> # Conflicts: # MissionPlanner.csproj

Forgot to push previous commit. This commit: Rewrite in progress

Note: CultureInfo can be evil (5,3 could be interpreted as 53 and so on)

modified: GCSViews/ConfigurationView/ConfigEnergyProfile.Designer.cs modified: GCSViews/ConfigurationView/ConfigEnergyProfile.cs modified: GCSViews/ConfigurationView/ConfigEnergyProfile.resx - restructured layout in "ConfigEnergyProfile" modified: GCSViews/FlightPlanner.Designer.cs modified: GCSViews/FlightPlanner.cs modified: GCSViews/FlightPlanner.resx - refactored the method "writeEnergyConsumption()" - implement data-bindigs deleted: Utilities/EnergyProfile.cs - delete old file new file: Utilities/EnergyProfileController.cs - new file with logical methods for the "EnergyProfile" - includes Import, Export, Plot, Interpolation, calculate-methods for energy-consumption new file: Utilities/EnergyProfileModel.cs# - static data-model for energyprofile - includes also the "CurrentModel" as class new file: Utilities/IConfigEnergyProfile.cs - implement 2 interfaces for adaptivity code - first interface "IConfigEnergyProfile" is only for the service in configuration View, the second "IEnergyConsumption" is for the service to calculate the energy-consumption in flight-planner

modified: GCSViews/ConfigurationView/ConfigEnergyProfile.Designer.cs GCSViews/ConfigurationView/ConfigEnergyProfile.cs GCSViews/ConfigurationView/ConfigEnergyProfile.resx - changed text and declarations from labels in view GCSViews/FlightPlanner.Designer.cs GCSViews/FlightPlanner.cs - changed text from label in panel (right) Utilities/EnergyProfileController.cs Utilities/EnergyProfileModel.cs - changed init-model - change Math.Round to 1

modified: GCSViews/ConfigurationView/ConfigEnergyProfile.Designer.cs modified: GCSViews/ConfigurationView/ConfigEnergyProfile.cs modified: GCSViews/ConfigurationView/ConfigEnergyProfile.resx - implement new config iput for velocity - implement new graph for velocity modified: GCSViews/FlightPlanner.Designer.cs modified: GCSViews/FlightPlanner.cs modified: GCSViews/FlightPlanner.resx - implement average flight time in WP-table - implement required flight time over all in panel at the right - change desight for the panel of the right - little changes in writeenergyconsumption() modified: Utilities/EnergyProfileController.cs - fixing "import energyprofile" - implement functionality to requirements (current or velocity) for plot an calculation - implement test-methods for calc-methods modified: Utilities/EnergyProfileModel.cs - implement new velocity model modified: Utilities/IConfigEnergyProfile.cs - interface was matched to requirements

- fixed Merge-Conflicts

TihKay · 2017-10-07T08:49:41Z

@meee1 We have just spent a few more minutes to reduce the number of
changed lines. That should make the review process a bit easier. The PR
is not small but I'm confident you'll see that the actual changes are
clear and mostly separate from existing logic.
Please let me know if any questions or concerns arise. I'd be happy to
answer or react on them in order to support a quick merge of the PR.
Best!

…nd create an energy-profile

- added missing inline documantation - make better naming in configenergyprofile.designer and write missing tooltips

meee1 · 2017-11-13T22:56:44Z

do you have a log to show this in action? i would like to review it as you intended it to be used.

TihKay · 2017-11-14T08:08:49Z

Hi,

I'm glad that you want to review my feature. In the zip file [0] below, there is a test profile, which you can simulate the energy consumption when creating a flight plan. You can easily import this test profile, then all the necessary data should be entered in the tables.

My work on the automatic analysis of logfiles from so-called "Benschmark flights", to create such individual energy-profiles, is progressing well. I guess, I could implement a first version in a few weeks.

ciao

[0] testprofile_SoloCopter.zip

velocity - add messages for user, if some values are incorrect

- fix bug in ConfigEnergyProfile

- insert comments

ThomDietrich · 2018-01-25T10:21:50Z

Hello @meee1,
just wanted to leave a friendly ping and wanted to hear what you think about our contribution. The first phase of the underlying project is completed and we are looking into next steps. It would be amazing to see the results merged soon. If you have any outstanding questions, comments or issues, please let us know.

Best! Thomas

ThomDietrich · 2018-04-13T10:37:01Z

@meee1 @magicrub yet again a friendly ping. It would be a real shame to see all the work invested in this PR be for nothing. It would be appreciated if you at least engaged in a conversation about your concerns and/or questions.
Best Regards! Thomas

aercamti · 2019-04-03T13:45:25Z

This looks like a helpful feature for flight planning and hope it will be implemented soon.

magicrub · 2019-04-03T18:45:44Z

this looks good, its up to @meee1 to merge.

Patrick Schneider and others added 30 commits December 13, 2016 19:20

Merge pull request #2 from ArduPilot/master

2d34fb6

Updating new Branch

Integrated column in the flight planner waypoint table for the energy…

9c872b0

… consumption feature. Energy consumption is shown as mAh (milliampere per hour)

Added menu for future feature energyprofile in Config/Tuning

f297d0c

Files for previous commit (added menu...)

2d9fbb6

Small update for Energyprofilemenu - content missing

4fff608

Fixed typo

27de9b7

Added random values (table flightplanner->EC) without considering the…

8dfedc1

… parameters for the energyconsumption of the multicopter (will be changed soon)

Added total energy consumption on the right side of the Action Panel

82d4b6b

Fix: show menu energyprofile independent of copterconnection

dbe72cf

Update: Energyconsumption now depends on parameters.

680dfec

todo: find appopriate function for I(angle) and v(angle)

EnergyEstimation - Backup

ad170a6

EnergyConsumption

776d38e

Update of I-approximation:

506c22a

For now linear approximation from -90 to 0 degree and 0 to 90 degree. 0 degree is the base energy consumption (hovering for example)

EC: Now the velocity is included in the EnergyConsumption-estimation.

0297e51

ToDo: -Polynom for I should be of grade 2 oder 3 -v could be relatively linear -linechart to see parameters in diagram (system.windows.forms.datavisualization)

implementation will follow (interpolation)

4273698

Implementation in progress. Backup

372956d

- Missing velocity

9bc4f01

function nearly complete

todo update (check for valid user input)

9ee5e66

Fully implemented linear approximation

5f40043

Small fix: forgot to convert km/h to m/s

6369fe0

Fix for fix: Velocity has to be in meters per HOURS (user has to ente…

05962ea

…r velocity in km/h; still the time was handled as seconds)...the distance is also given in meters, not kilometers

Merge remote-tracking branch 'origin/master' into feature/energyprofile

27e71c5

Signed-off-by: Thomas Dietrich <[email protected]> # Conflicts: # MissionPlanner.csproj

Fix for broken csproj

e807f56

EnergyProfile can now be enabled/disabled

5aa8fa4

Forgot to push previous commit. This commit: Rewrite in progress

Sample design for energyprofile implemented

fd42f6f

Write consumption values into settings string

283ede9

Nearly done, fixed energycalculation (A converted to mA, m/s to m/h).

57c5853

Note: CultureInfo can be evil (5,3 could be interpreted as 53 and so on)

small renaming fixes

0841d12

polynom for I (regression)

b1d0812

Polynom for V (Gaussian interpolated)

e6fed61

TihKay and others added 6 commits June 21, 2017 16:10

- re-design of configuration-panel

a48e226

Merge branch 'feature/energyprofile' into energy-profile

52c85d8

- fixed Merge-Conflicts

Revert arrangement and line ending changes

97a48ba

ThomDietrich force-pushed the energy-profile branch from 6ea3fea to 97a48ba Compare October 6, 2017 12:01

TihKay added 2 commits November 10, 2017 13:46

- implement a LogAnalyzer for EnergyProfile ... it parsing Logfiles a…

14da05d

…nd create an energy-profile

- implement a feedback-box for the user after an analysis

fd1efb2

- added missing inline documantation - make better naming in configenergyprofile.designer and write missing tooltips

meee1 force-pushed the master branch from 99bfe0e to 344aa3d Compare December 4, 2017 05:54

TihKay added 3 commits December 5, 2017 17:00

- add a cubic-spline algorithm as interpolation method for current and

faa3bba

velocity - add messages for user, if some values are incorrect

- fixing calc_gps_speed ... gps_alt instead cmd_alt

fcd8981

- fix bug in ConfigEnergyProfile

- fix bug, if energyconfigview reinit the interpbox

98c5e24

meee1 force-pushed the master branch from f661536 to 4e011e7 Compare December 12, 2017 13:15

meee1 force-pushed the master branch from e152583 to 5ad4665 Compare December 20, 2017 04:16

- fix little bugs

f1c943e

- insert comments

meee1 force-pushed the master branch 2 times, most recently from 303616c to d3b17db Compare August 23, 2019 00:49

meee1 force-pushed the master branch from 5b3fb21 to 781acb9 Compare March 7, 2020 10:53

meee1 force-pushed the master branch 3 times, most recently from 0614891 to 7d31d41 Compare June 20, 2021 22:51

meee1 force-pushed the master branch from 187f990 to c80ffa8 Compare April 7, 2022 07:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

new feature: Energy-Profile #1652

new feature: Energy-Profile #1652

Uh oh!

TihKay commented Sep 28, 2017

Uh oh!

TihKay commented Oct 7, 2017

Uh oh!

meee1 commented Nov 13, 2017

Uh oh!

TihKay commented Nov 14, 2017

Uh oh!

ThomDietrich commented Jan 25, 2018

Uh oh!

ThomDietrich commented Apr 13, 2018

Uh oh!

aercamti commented Apr 3, 2019

Uh oh!

magicrub commented Apr 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

new feature: Energy-Profile #1652

Are you sure you want to change the base?

new feature: Energy-Profile #1652

Uh oh!

Conversation

TihKay commented Sep 28, 2017

Uh oh!

TihKay commented Oct 7, 2017

Uh oh!

meee1 commented Nov 13, 2017

Uh oh!

TihKay commented Nov 14, 2017

Uh oh!

ThomDietrich commented Jan 25, 2018

Uh oh!

ThomDietrich commented Apr 13, 2018

Uh oh!

aercamti commented Apr 3, 2019

Uh oh!

magicrub commented Apr 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants