[BUG FIX] Fix draw_debug tutorial types#1413
Merged
YilingQiao merged 6 commits intoGenesis-Embodied-AI:mainfrom Jul 18, 2025
Merged
[BUG FIX] Fix draw_debug tutorial types#1413YilingQiao merged 6 commits intoGenesis-Embodied-AI:mainfrom
YilingQiao merged 6 commits intoGenesis-Embodied-AI:mainfrom
Conversation
Collaborator
|
Thanks, I will merge it after a few other PRs are merged. Then I can update it to the main branch. |
duburcqa
previously requested changes
Jul 15, 2025
Collaborator
duburcqa
left a comment
duburcqa
left a comment
There was a problem hiding this comment.
Could you rather modify draw_debug_line to systematically cast input to numpy using np.asarray(start, dtype=np.float32) (same for end and probably color?).
duburcqa
changed the title
YilingQiao
approved these changes
Jul 18, 2025
YilingQiao
dismissed
duburcqa’s stale review
The PR is modified following the review.
chris-la-humalab
pushed a commit
to HumaLab/Genesis
that referenced
this pull request
Aug 1, 2025
Co-authored-by: YilingQiao <[email protected]>
LeonLiu4
pushed a commit
to LeonLiu4/Genesis
that referenced
this pull request
Aug 7, 2025
Co-authored-by: YilingQiao <[email protected]>
YilingQiao
added a commit
to YilingQiao/Genesis
that referenced
this pull request
Aug 22, 2025
Co-authored-by: YilingQiao <[email protected]>
winnieyangwannan
pushed a commit
to winnieyangwannan/Genesis
that referenced
this pull request
Sep 14, 2025
Co-authored-by: YilingQiao <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simple fix for
draw_debugtutorial types as it currently seems to be broken due to the following error:Motivation and Context
Looking to contribute to Genesis development. First step is to ensure all tutorials are working fine.
How Has This Been / Can This Be Tested?
Run
draw_debugscript without errors.