Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace string serialisation with enum for HostSex categories #849

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace string serialisation with enum for HostSex categories #849

wants to merge 1 commit into from

Conversation

jfy133
Copy link
Collaborator

@jfy133 jfy133 commented Aug 15, 2024

Additional questions I have:

  • Is there a CHANGELOG I should update?
  • Should I remove the annotation that the expected value is an enumeration?
  • Is there any other areas of the file I should update?
  • Are there any other files I need to update?
  • Do I need to run any other scripts or generate anything else?

@jfy133 jfy133 requested a review from turbomam August 15, 2024 08:12
@turbomam
Copy link
Member

see also

which includes more repairs along the same lines, but also introduces excessive formatting changes

I recommend merging this as soon as possible

turbomam
turbomam approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@turbomam turbomam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent first contribution to mixs.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbomam turbomam turbomam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfy133 @turbomam