-
Notifications
You must be signed in to change notification settings - Fork 7
feat: Add fisherman service scaffold #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
snowmead
wants to merge
5
commits into
main
Choose a base branch
from
snowmead/feat-fisherman-service-core
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 23, 2025
- Create fisherman-service crate with actor-based architecture - Add ProcessFileDeletionRequest event and handler structure - Implement fisherman_process_file_deletion task (placeholder) - Add fisherman-service to workspace members - Register fisherman task module The fisherman service monitors file deletion requests and will construct proofs of inclusion for storage providers to safely remove files from their Merkle forests. 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
8eb66e0
to
25c0437
Compare
ffarall
requested changes
Jul 28, 2025
ffarall
reviewed
Jul 28, 2025
This was referenced Jul 30, 2025
…cture (#432) - Add FileOperationIntention and FileOperation types to common types - Replace file key/deletion target with signed file operation intention in events - Remove database dependency from fisherman service constructor - Update ProcessFileDeletionRequest command to include signed intention data - Streamline task handling to use structured signed intentions
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added a new Fisherman Service to monitor and process file deletion requests in the StorageHub network.
What changed?
shc-fisherman-service
crate with the following components:FishermanService
actor that monitors blockchain events for file deletion requestsProcessFileDeletionRequest
)FileDeletionTarget
enum to specify where files should be deleted from (BSP or Bucket)FishermanProcessFileDeletionTask
to handle the construction of proofs and submission to the blockchainWhy make this change?
The Fisherman Service is a critical component for permissionless file deletion in the StorageHub network. It enables: