-
Notifications
You must be signed in to change notification settings - Fork 7
feat: Add fisherman database migrations and fishing indexer mode #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
snowmead
wants to merge
8
commits into
snowmead/feat-fisherman-service-core
Choose a base branch
from
snowmead/feat-fisherman-migrations-indexing
base: snowmead/feat-fisherman-service-core
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Add fisherman database migrations and fishing indexer mode #423
snowmead
wants to merge
8
commits into
snowmead/feat-fisherman-service-core
from
snowmead/feat-fisherman-migrations-indexing
+434
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 23, 2025
5b22334
to
e9916c5
Compare
8eb66e0
to
25c0437
Compare
69399eb
to
d9ef814
Compare
This was referenced Jul 30, 2025
- Add MSP-file and BSP-file association tables via dedicated migrations - Implement fishing mode handler for targeted event filtering - Add IndexerMode enum with full, lite, and fishing modes - Update models to track MSP/BSP file associations - Handle file deletions in BspConfirmStoppedStoring events - Add conflict handling for duplicate file associations The fishing mode indexes only essential events needed for fisherman monitoring: file operations, provider associations, and bucket lifecycle. 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
This ensures proper joins between bsp_file and bsp tables in database queries.
- Create configure_and_spawn_indexer_fisherman() function to eliminate code duplication - Replace 4 identical code blocks across different service initialization functions - Consolidates indexer mode determination, validation, and service spawning logic 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add FileDeletionRequested event to fishing handler event matching - Simplify MspFile::insert to use execute() instead of get_result()
5a9748f
to
54b1f27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Restructured database schema for file associations and added fisherman indexing.
What changed?
bsp_file
table from the initial file migration into its own migrationmsp_file
association table to track which MSP is storing which files