feat: Add fisherman integration tests #424
Open
+1,164
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
snowmead
force-pushed
the
snowmead/feat-fisherman-migrations-indexing
branch
from
5b22334 to
e9916c5
Compare
snowmead
force-pushed
the
snowmead/feat-fisherman-integration-tests
branch
2 times, most recently
from
2c95e1b to
b2b0435
Compare
snowmead
changed the title
snowmead
force-pushed
the
snowmead/feat-fisherman-integration-tests
branch
from
b2b0435 to
b6b3b09
Compare
snowmead
force-pushed
the
snowmead/feat-fisherman-migrations-indexing
branch
from
69399eb to
d9ef814
Compare
snowmead
force-pushed
the
snowmead/feat-fisherman-integration-tests
branch
2 times, most recently
from
ac687f0 to
bca30de
Compare
- Add fisherman service spawning in node service layer - Configure automatic indexer mode selection for fisherman nodes - Add fisherman node to Docker fullnet configuration - Implement fisherman support in test infrastructure - Add createFishermanApi to FullNetContext for test access - Configure test runners to support fisherman and indexer modes - Add fisherman test scripts to package.json - Include comprehensive integration tests for fisherman functionality The fisherman service now integrates seamlessly with the node, automatically enabling the indexer in fishing mode when needed. 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
Prevent potential errors when disconnecting undefined API instances in test cleanup.
- Fix createFishermanApi not being properly added to test context in testrunner - Changed from checking fishermanApiPromise to checking fullNetConfig.fisherman - Add createFishermanApi conditionally after context creation - Add TypeScript type annotations for createApi endpoint parameters - Update expected log message in fisherman-default-mode test to match actual output - Changed from 'Fishing (file tracking only) mode\!' to 'Fishing mode\!' - Fix fisherman indexer mode configuration in Docker setup - Always add --indexer-mode flag when fishermanIndexerMode is specified - Ensures fisherman node runs with correct indexer mode (fishing) - Update indexer-fishing test to use proper test utilities and remove duplicated code
… storage confirmation - Replace manual event checking with existing wait helper methods for BSP volunteer flow - Consolidate MSP response event handling to check only for MspAcceptedStorageRequest - Remove unnecessary value proposition query logic in createBucketAndSendNewStorageRequest - Add BSP account parameter to bspStored wait helper for better specificity - Increase timeout for BSP storage confirmation in file deletion test 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
snowmead
force-pushed
the
snowmead/feat-fisherman-migrations-indexing
branch
from
5a9748f to
54b1f27
Compare
snowmead
force-pushed
the
snowmead/feat-fisherman-integration-tests
branch
from
bca30de to
c75182e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added a dedicated fisherman node with specialized indexer mode for monitoring the network.
What changed?
sh-fishermanservice to the Docker compose template with appropriate configurationfisherman-default-mode.test.ts- Tests basic fisherman node setup and indexer operationindexer-fishing.test.ts- Comprehensive tests for the fishing mode functionalityindexer-modes-comparison.test.ts- Compares behavior across different indexer modes