-
-
Notifications
You must be signed in to change notification settings - Fork 577
[14.0] [MIG] account_payment_order: Migration to v14 #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0] [MIG] account_payment_order: Migration to v14 #769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Just some comments to the README that can improve the documentation.
2dc2ad8 to
e403683
Compare
|
@joao-p-marques Changes done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you reused some work from the previous PR? If so, you have to at least add the contributor, and preserve commits if applicable
@alexis-via @StefanRijnhart are you going to review this?
…the Sorrento Code sprint 2016 Improvements include: - full re-organisation of modules and big re-organisation of the code - simplification of the code related to the fact that support for direct debit is now in t he base module, not added by an optional module account_direct_debit (module was removed) - new design of the wizard to select move lines to pay - support for non-SEPA file transfer- - support for German direct debit SEPA files (fixes bug OCA#129) - remove workflow of payment.order - add wizard of selection of move lines to pay
* IMP: prevent deleting a move-line that is linked to a payment order line * FIX: better filtering of move lines already included in open payment order
Take into account all the remaining remarks of Frederic Clementi dated May 30: - see multi-currency amounts in the wizard to add transaction lines - add help msg on bank payment lines
* IMP: extensibility of _prepare_move Pass the list of bank lines to _prepare_move so it is possible to customize the move (eg it's name) based on the lines being paid. * FIX: payment order: add missing onchange dependencies in move selection wizard
* Fix crash when selecting a customer that has a direct debit payment mode but no mandate * Hide many fields when payment_order_ok is False on a payment_mode * Fix payment line communication when the move line is not linked to an invoice (problem found when porting donation_debit_debit to v9) * For the communication field, if self.move_id.ref is False, fallback on self.move_id.name
Port almost all modules to v10 * Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)
* FIX: Bug OCA#353 crash when selecting a payment mode that has a variable link to a bank account * FIX: Add 'post_move' option on account.payment.mode with default True, to keep the previous behavior * IMP: Explicit error when bank account is missing on bank journal * IMP: Add field default_date_prefered on payment mode.
…ent order + allow to cancel an uploaded payment order
* Restrict the deletion of bank payment line * Add test_cancel_payment_order
…lines Case: The bank account isn't set properly in the payment order lines, because the bank account is only got from account.move.line or the first bank account in the partner_id, but never from the invoice (account.move). Solution: With this fix, the bank account will be get from account.move when matching the criteria.
Case: User can't add invoices to payment/debit orders from the tree view but it's still possible to add them one by one from the form view. - Remove binding_views="form": by default are "tree & form". With this fix, users can add payment/debit orders from the invoice tree view
Case: After the configuration of a debit order and generating the .xml file, user can't download it from the next step screen using the download link. This fix makes the .xml file downloadable from the .xml file name as it was in older versions
Currently translated at 100.0% (220 of 220 strings) Translation: bank-payment-13.0/bank-payment-13.0-account_payment_order Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_payment_order/es_AR/
Currently translated at 100.0% (220 of 220 strings) Translation: bank-payment-13.0/bank-payment-13.0-account_payment_order Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_payment_order/es_AR/
Currently translated at 100.0% (220 of 220 strings) Translation: bank-payment-13.0/bank-payment-13.0-account_payment_order Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_payment_order/es_AR/
8646a72 to
df8bd78
Compare
df8bd78 to
a7a5006
Compare
|
@StefanRijnhart change done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Tested and reviewed the changes with the earlier PR.
|
@pedrobaeza change on commits and Contributors done! |
|
Great, thanks to all: /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 3c88a27. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT26418
This PR superseds #749 adding the suggested changes of @alexis-via and @StefanRijnhart because the author doesn't attend his PR since 24 Oct 2020.
Please review it, @pedrobaeza @joao-p-marques