Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] product_packaging_dimension: Migration to 18.0 #1752

Merged

Conversation

LucasTran380381
Copy link

@LucasTran380381 LucasTran380381 commented Oct 25, 2024

clementmbr and others added 21 commits October 23, 2024 14:36
…ply query if column max_weight exists.

This column is no longer defined in 16.0
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_dimension
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_dimension/
@LucasTran380381 LucasTran380381 force-pushed the 18.0-mig-product_packaging_dimension branch from dbae329 to b8de6fe Compare October 25, 2024 05:07
@rousseldenis
Copy link
Contributor

/ocabot migration product_packaging_dimension

@rousseldenis
Copy link
Contributor

@LucasTran380381 Thanks for this. Don't hesitate to put link to depending PR's in this one's description in order to easy review.

Copy link

@nguyenminhchien nguyenminhchien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@simahawk
Copy link
Contributor

@LucasTran380381 the dependency PR got merged.

@LucasTran380381 LucasTran380381 force-pushed the 18.0-mig-product_packaging_dimension branch from b8de6fe to 121bd23 Compare December 23, 2024 02:48
@LucasTran380381
Copy link
Author

LucasTran380381 commented Dec 23, 2024

@LucasTran380381 the dependency PR got merged.

@simahawk removed PR dependency unreleased

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rvalyi
Copy link
Member

rvalyi commented Dec 30, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1752-by-rvalyi-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 03a158f into OCA:18.0 Dec 30, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 00e9629. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.