-
-
Notifications
You must be signed in to change notification settings - Fork 773
[18.0][MIG] product_variant_route_mto (was stock_product_variant_mto) #1970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
OCA-git-bot
merged 7 commits into
OCA:18.0
from
jbaudoux:product-attribute-18.0-mig-product_variant_route_mto
May 28, 2025
Merged
[18.0][MIG] product_variant_route_mto (was stock_product_variant_mto) #1970
OCA-git-bot
merged 7 commits into
OCA:18.0
from
jbaudoux:product-attribute-18.0-mig-product_variant_route_mto
May 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaudoux
commented
May 7, 2025
a1f419d
to
76cc7e8
Compare
8ab7885
to
8c97f98
Compare
/ocabot migration product_variant_route_mto |
sebalix
reviewed
May 20, 2025
8c97f98
to
cd7a462
Compare
sebalix
approved these changes
May 21, 2025
simahawk
approved these changes
May 28, 2025
Define route_ids as computed on the product variant, in order to reuse route_ids from its template and add or remove MTO route according to the setting on the variant. In case MTO route is changed on the template, it must reset any variant specific setting.
into product_variant_route_mto
that relies on stock_route_mto
cd7a462
to
3b60890
Compare
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 02b8ec1. Thanks a lot for contributing to OCA. ❤️ |
victoralmau
pushed a commit
to Tecnativa/product-attribute
that referenced
this pull request
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MOD] I forbid to set a variant as non MTO when the product is MTO as this is confusing. You can only set a variant as MTO when the product is not MTO ( cc @Highcooley )
Depends on:
Replaces: (I moved fixes from the migration commit into a separate commit)
cc @sebalix @simahawk @grindtildeath