Skip to content

Conversation

jbaudoux
Copy link
Contributor

@jbaudoux jbaudoux commented May 7, 2025

[MOD] I forbid to set a variant as non MTO when the product is MTO as this is confusing. You can only set a variant as MTO when the product is not MTO ( cc @Highcooley )

Depends on:

Replaces: (I moved fixes from the migration commit into a separate commit)

cc @sebalix @simahawk @grindtildeath

@jbaudoux jbaudoux force-pushed the product-attribute-18.0-mig-product_variant_route_mto branch from a1f419d to 76cc7e8 Compare May 7, 2025 14:46
@jbaudoux jbaudoux changed the title [18.0][MIG] product_variant_rout_mto (was stock_product_variant_mto) [18.0][MIG] product_variant_route_mto (was stock_product_variant_mto) May 7, 2025
@jbaudoux jbaudoux force-pushed the product-attribute-18.0-mig-product_variant_route_mto branch 3 times, most recently from 8ab7885 to 8c97f98 Compare May 7, 2025 18:34
@jbaudoux jbaudoux marked this pull request as ready for review May 7, 2025 18:37
@sebalix
Copy link
Contributor

sebalix commented May 20, 2025

/ocabot migration product_variant_route_mto

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone May 20, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request May 20, 2025
61 tasks
@jbaudoux jbaudoux force-pushed the product-attribute-18.0-mig-product_variant_route_mto branch from 8c97f98 to cd7a462 Compare May 20, 2025 09:45
mmequignon and others added 7 commits May 28, 2025 13:41
Define route_ids as computed on the product variant, in order to
reuse route_ids from its template and add or remove MTO route
according to the setting on the variant.

In case MTO route is changed on the template, it must reset any
variant specific setting.
into product_variant_route_mto
@jbaudoux jbaudoux force-pushed the product-attribute-18.0-mig-product_variant_route_mto branch from cd7a462 to 3b60890 Compare May 28, 2025 11:41
@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1970-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c86f6a2 into OCA:18.0 May 28, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 02b8ec1. Thanks a lot for contributing to OCA. ❤️

victoralmau pushed a commit to Tecnativa/product-attribute that referenced this pull request Jul 10, 2025
Signed-off-by simahawk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants