Skip to content

[Feature]: ERC721Wrapper extension #1854

[Feature]: ERC721Wrapper extension

[Feature]: ERC721Wrapper extension #1854

Triggered via pull request December 17, 2024 03:33
Status Success
Total duration 1m 38s
Artifacts

check.yml

on: pull_request
nightly / fmt
21s
nightly / fmt
nightly / doc
54s
nightly / doc
ubuntu / stable / features
1m 24s
ubuntu / stable / features
ubuntu / stable / typos
3s
ubuntu / stable / typos
Matrix: clippy
Fit to window
Zoom out
Zoom in

Annotations

36 warnings
ubuntu / stable / typos
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
nightly / fmt
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
stable / clippy
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
stable / clippy: contracts/src/token/erc721/extensions/wrapper.rs#L54
[clippy] reported by reviewdog 🐶 warning: unused variable: `length` --> contracts/src/token/erc721/extensions/wrapper.rs:54:13 | 54 | let length = token_ids.len(); | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_length` | = note: `#[warn(unused_variables)]` on by default Raw Output: contracts/src/token/erc721/extensions/wrapper.rs:54:13:w:warning: unused variable: `length` --> contracts/src/token/erc721/extensions/wrapper.rs:54:13 | 54 | let length = token_ids.len(); | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_length` | = note: `#[warn(unused_variables)]` on by default __END__
stable / clippy: contracts/src/token/erc721/extensions/wrapper.rs#L51
[clippy] reported by reviewdog 🐶 warning: unused variable: `account` --> contracts/src/token/erc721/extensions/wrapper.rs:51:9 | 51 | account: Address, | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_account` Raw Output: contracts/src/token/erc721/extensions/wrapper.rs:51:9:w:warning: unused variable: `account` --> contracts/src/token/erc721/extensions/wrapper.rs:51:9 | 51 | account: Address, | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_account` __END__
stable / clippy: contracts/src/token/erc721/extensions/wrapper.rs#L52
[clippy] reported by reviewdog 🐶 warning: this argument is passed by value, but not consumed in the function body --> contracts/src/token/erc721/extensions/wrapper.rs:52:20 | 52 | token_ids: Vec<U256>, | ^^^^^^^^^ help: consider changing the type to: `&[U256]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value = note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]` Raw Output: contracts/src/token/erc721/extensions/wrapper.rs:52:20:w:warning: this argument is passed by value, but not consumed in the function body --> contracts/src/token/erc721/extensions/wrapper.rs:52:20 | 52 | token_ids: Vec<U256>, | ^^^^^^^^^ help: consider changing the type to: `&[U256]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value = note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]` __END__
stable / clippy: contracts/src/token/erc721/extensions/wrapper.rs#L60
[clippy] reported by reviewdog 🐶 warning: this method could have a `#[must_use]` attribute --> contracts/src/token/erc721/extensions/wrapper.rs:60:5 | 60 | pub fn underlying(&self) -> &Erc721 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn underlying(&self) -> &Erc721` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate = note: `-W clippy::must-use-candidate` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::must_use_candidate)]` Raw Output: contracts/src/token/erc721/extensions/wrapper.rs:60:5:w:warning: this method could have a `#[must_use]` attribute --> contracts/src/token/erc721/extensions/wrapper.rs:60:5 | 60 | pub fn underlying(&self) -> &Erc721 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn underlying(&self) -> &Erc721` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate = note: `-W clippy::must-use-candidate` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::must_use_candidate)]` __END__
stable / clippy: contracts/src/token/erc721/extensions/wrapper.rs#L61
[clippy] reported by reviewdog 🐶 warning: used underscore-prefixed binding --> contracts/src/token/erc721/extensions/wrapper.rs:61:10 | 61 | &self._underlying | ^^^^^^^^^^^^^^^^ | note: binding is defined here --> contracts/src/token/erc721/extensions/wrapper.rs:20:5 | 20 | pub _underlying: Erc721, | ^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#used_underscore_binding Raw Output: contracts/src/token/erc721/extensions/wrapper.rs:61:10:w:warning: used underscore-prefixed binding --> contracts/src/token/erc721/extensions/wrapper.rs:61:10 | 61 | &self._underlying | ^^^^^^^^^^^^^^^^ | note: binding is defined here --> contracts/src/token/erc721/extensions/wrapper.rs:20:5 | 20 | pub _underlying: Erc721, | ^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#used_underscore_binding __END__
beta / clippy
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
beta / clippy: contracts/src/token/erc721/extensions/wrapper.rs#L54
[clippy] reported by reviewdog 🐶 warning: unused variable: `length` --> contracts/src/token/erc721/extensions/wrapper.rs:54:13 | 54 | let length = token_ids.len(); | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_length` | = note: `#[warn(unused_variables)]` on by default Raw Output: contracts/src/token/erc721/extensions/wrapper.rs:54:13:w:warning: unused variable: `length` --> contracts/src/token/erc721/extensions/wrapper.rs:54:13 | 54 | let length = token_ids.len(); | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_length` | = note: `#[warn(unused_variables)]` on by default __END__
beta / clippy: contracts/src/token/erc721/extensions/wrapper.rs#L51
[clippy] reported by reviewdog 🐶 warning: unused variable: `account` --> contracts/src/token/erc721/extensions/wrapper.rs:51:9 | 51 | account: Address, | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_account` Raw Output: contracts/src/token/erc721/extensions/wrapper.rs:51:9:w:warning: unused variable: `account` --> contracts/src/token/erc721/extensions/wrapper.rs:51:9 | 51 | account: Address, | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_account` __END__
beta / clippy: contracts/src/token/erc721/extensions/wrapper.rs#L52
[clippy] reported by reviewdog 🐶 warning: this argument is passed by value, but not consumed in the function body --> contracts/src/token/erc721/extensions/wrapper.rs:52:20 | 52 | token_ids: Vec<U256>, | ^^^^^^^^^ help: consider changing the type to: `&[U256]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value = note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]` Raw Output: contracts/src/token/erc721/extensions/wrapper.rs:52:20:w:warning: this argument is passed by value, but not consumed in the function body --> contracts/src/token/erc721/extensions/wrapper.rs:52:20 | 52 | token_ids: Vec<U256>, | ^^^^^^^^^ help: consider changing the type to: `&[U256]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value = note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]` __END__
beta / clippy: contracts/src/token/erc721/extensions/wrapper.rs#L60
[clippy] reported by reviewdog 🐶 warning: this method could have a `#[must_use]` attribute --> contracts/src/token/erc721/extensions/wrapper.rs:60:5 | 60 | pub fn underlying(&self) -> &Erc721 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn underlying(&self) -> &Erc721` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate = note: `-W clippy::must-use-candidate` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::must_use_candidate)]` Raw Output: contracts/src/token/erc721/extensions/wrapper.rs:60:5:w:warning: this method could have a `#[must_use]` attribute --> contracts/src/token/erc721/extensions/wrapper.rs:60:5 | 60 | pub fn underlying(&self) -> &Erc721 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn underlying(&self) -> &Erc721` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate = note: `-W clippy::must-use-candidate` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::must_use_candidate)]` __END__
beta / clippy: contracts/src/token/erc721/extensions/wrapper.rs#L61
[clippy] reported by reviewdog 🐶 warning: used underscore-prefixed binding --> contracts/src/token/erc721/extensions/wrapper.rs:61:10 | 61 | &self._underlying | ^^^^^^^^^^^^^^^^ | note: binding is defined here --> contracts/src/token/erc721/extensions/wrapper.rs:20:5 | 20 | pub _underlying: Erc721, | ^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#used_underscore_binding Raw Output: contracts/src/token/erc721/extensions/wrapper.rs:61:10:w:warning: used underscore-prefixed binding --> contracts/src/token/erc721/extensions/wrapper.rs:61:10 | 61 | &self._underlying | ^^^^^^^^^^^^^^^^ | note: binding is defined here --> contracts/src/token/erc721/extensions/wrapper.rs:20:5 | 20 | pub _underlying: Erc721, | ^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#used_underscore_binding __END__
nightly / doc
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
nightly / doc: contracts/src/access/control.rs#L125
unexpected `cfg` condition value: `export-abi`
nightly / doc: contracts/src/access/ownable.rs#L129
unexpected `cfg` condition value: `export-abi`
nightly / doc: contracts/src/access/ownable_two_step.rs#L149
unexpected `cfg` condition value: `export-abi`
nightly / doc: contracts/src/finance/vesting_wallet.rs#L350
unexpected `cfg` condition value: `export-abi`
nightly / doc: contracts/src/token/erc1155/extensions/metadata_uri.rs#L57
unexpected `cfg` condition value: `export-abi`
nightly / doc: contracts/src/token/erc1155/extensions/supply.rs#L83
unexpected `cfg` condition value: `export-abi`
nightly / doc: contracts/src/token/erc1155/mod.rs#L387
unexpected `cfg` condition value: `export-abi`
nightly / doc: contracts/src/token/erc20/extensions/capped.rs#L53
unexpected `cfg` condition value: `export-abi`
nightly / doc: contracts/src/token/erc20/extensions/metadata.rs#L63
unexpected `cfg` condition value: `export-abi`
nightly / doc: contracts/src/token/erc20/extensions/permit.rs#L84
unexpected `cfg` condition value: `export-abi`
ubuntu / stable / features
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636