-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved GCS parameter readablity #23376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be exposing the value of the enums at all. I propose we instead remove the numbering in the long description.
The problem there is that the parameter is referenced by the numbers in the docs, so if we move away from the numbers, its even less clear what does what. |
Isn't that just more of the same problem? We should only be using the descriptive names everywhere right? |
See PX4/PX4-user_guide#3287 |
5e511e4
to
a126093
Compare
incoperated feedback sd
a126093
to
186a62c
Compare
Co-authored-by: Hamish Willee <[email protected]>
improved GCS parameter description Co-authored-by: Hamish Willee <[email protected]> Co-authored-by: Silvan Fuhrer <[email protected]>
The Description for the MPC_POS_MODE Parameters was not clear, as only 0,3, 4 are used, but in the dropdown this was not obvious.
now is clearer what, what is.