Commander: only add *autopilot disengaged* to failsafe notifactions in special cases #23543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
In a generic failsafe, the message "autopilot disengaged" is wrong. E.g. it now displays the following for a Land failsafe due to geofence breach:
Solution
Only keep the "autopilot disengaged" in case the autopilot is no longer controlling the vehicle's position. This is a bit arbitrary but I guess the best approximation to what "autopilot disengaged" implies, as then without any user input the vehicle will likely crash - thus the extra warning with the implication that the pilot should take over control if possible.
With this change the geofence breach failsafe notification would looks like this:
Changelog Entry
For release notes:
Context
This was originally added in #22902.