Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commander: only add *autopilot disengaged* to failsafe notifactions in special cases #23543

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

sfuhrer
Copy link
Contributor

@sfuhrer sfuhrer commented Aug 14, 2024

Solved Problem

In a generic failsafe, the message "autopilot disengaged" is wrong. E.g. it now displays the following for a Land failsafe due to geofence breach:
image

Solution

Only keep the "autopilot disengaged" in case the autopilot is no longer controlling the vehicle's position. This is a bit arbitrary but I guess the best approximation to what "autopilot disengaged" implies, as then without any user input the vehicle will likely crash - thus the extra warning with the implication that the pilot should take over control if possible.

With this change the geofence breach failsafe notification would looks like this:
image

Changelog Entry

For release notes:

Improvement: Commander: only add *autopilot disengaged* to failsafe notifactions in special cases

Context

This was originally added in #22902.

@sfuhrer sfuhrer requested a review from bresch August 14, 2024 12:56
@bresch bresch merged commit 4a3cbec into main Aug 16, 2024
95 checks passed
@bresch bresch deleted the pr-commander-remove-autopilot-disengaged-main branch August 16, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants