Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flash savings] px4_fmu-v6x: remove COMMON_MAGNETOMETER #23871

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dakejahl
Copy link
Contributor

The px4_fmu-v6x target is always out of flash. This blocks merging for everyone because CI doesn't pass. This kinda feels the same as someone using the last of the toilet paper and not replacing the roll...

23.5kB flash savings

Before

Memory region         Used Size  Region Size  %age Used
        ITCM_RAM:          0 GB        64 KB      0.00%
           FLASH:     1946736 B      1920 KB     99.02%
       DTCM1_RAM:          0 GB        64 KB      0.00%
       DTCM2_RAM:          0 GB        64 KB      0.00%
        AXI_SRAM:      100284 B       512 KB     19.13%
           SRAM1:          0 GB       128 KB      0.00%
           SRAM2:          0 GB       128 KB      0.00%
           SRAM3:          0 GB        32 KB      0.00%
           SRAM4:          2 KB        64 KB      3.12%
          BKPRAM:          0 GB         4 KB      0.00%

After

Memory region         Used Size  Region Size  %age Used
        ITCM_RAM:          0 GB        64 KB      0.00%
           FLASH:     1923272 B      1920 KB     97.82%
       DTCM1_RAM:          0 GB        64 KB      0.00%
       DTCM2_RAM:          0 GB        64 KB      0.00%
        AXI_SRAM:      100284 B       512 KB     19.13%
           SRAM1:          0 GB       128 KB      0.00%
           SRAM2:          0 GB       128 KB      0.00%
           SRAM3:          0 GB        32 KB      0.00%
           SRAM4:          2 KB        64 KB      3.12%
          BKPRAM:          0 GB         4 KB      0.00%

@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-sync-q-a-nov-6-2024/42264/1

bresch
bresch previously approved these changes Nov 7, 2024
@bresch bresch self-requested a review November 7, 2024 08:57
@bresch bresch dismissed their stale review November 7, 2024 08:58

We would then lose support of many external magnetometers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants