added a kill command in pxh console to kill the whole process including gz server #23881
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
reviewed
Nov 8, 2024
| int ret = system("pkill -9 -f gz"); | ||
| (void)ret; // Suppress warning about unused return value | ||
| printf("Killed gz...\n"); | ||
| ret = system("pkill -9 -f px4"); |
There was a problem hiding this comment.
This seems wrong, why should px4 kill itself with pkill? Is there a reason we can't shutdown cleanly in the first place?
dagar
reviewed
Nov 8, 2024
| fflush(stdout); | ||
|
|
||
| // Force kill all child processes | ||
| int ret = system("pkill -9 -f gz"); |
There was a problem hiding this comment.
We don't necessarily want to kill gazebo everytime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution is related to this issue:
#23880