ARK Hardware Docs #25991
ARK Hardware Docs #25991
Conversation
|
Hey @patrikpordi can you please remove the submodule updates so reviews can be cleaner? Thanks! |
patrikpordi
force-pushed
the
ARK_Docs
branch
2 times, most recently
from
894ee9d to
d9c7e54
Compare
| @@ -0,0 +1,59 @@ | |||
| # ARK 12S Payload Power Module | |||
There was a problem hiding this comment.
How does this differ from https://docs.px4.io/main/en/power_module/ark_12s_pab_power_module
There was a problem hiding this comment.
Specifically I mean the names are a little similar and readers might not differentiate their purpose.
There was a problem hiding this comment.
It has a payload connector to power additional devices
There was a problem hiding this comment.
I think this is worth having separately
There was a problem hiding this comment.
@patrikpordi Absolutely worth having separately. My point is that the reason for this "connector to power additional devices" is not obvious, so it isn't clear why you would chose this.
I've added a clarification in b1a3039
This is similar to the ARK 12S PAB Power Module except that the additional 12V 6A supply allows easier powering of a payload.
| @@ -0,0 +1,47 @@ | |||
| # ARK PAB Power Module No Connector | |||
There was a problem hiding this comment.
How is his different than the ARK PAB Power Module? I find this confusing.
There was a problem hiding this comment.
Note, I have added all the new docs except for this to the sidebar - that was what the "flaw checker" errors were mostly about.
There was a problem hiding this comment.
It is the same, only a version that does no have connectors attached to the power module, some people might want to solder the cables and not to use connectors.
There was a problem hiding this comment.
This might be better just to be included in the ARK PAB Power Module as an option.
There was a problem hiding this comment.
I think so, if it has no other differences. I'll leave that to you
hamishwillee
left a comment
hamishwillee
left a comment
There was a problem hiding this comment.
This looks great thanks @patrikpordi - awful lot to review though, so I'll have another look after you've responded to my comments.
|
@hamishwillee Thank you! |
|
@hamishwillee Also I sent you a message about the ESC docs on discord. We should revise that! |
…dules - Added DAN, SAM, SAM Mini, X20, RTK L1 L5 GPS modules - Added ARK distance sensors documentation - Added ARK power modules documentation
hamishwillee
force-pushed
the
ARK_Docs
branch
from
b0ea214 to
b62ea44
Compare
|
|
||
|  | ||
|
|
||
| This power module is also available without connectors: |
There was a problem hiding this comment.
FYI, I just moved the text a bit. Makes it more clear what you're looking at.
|
No flaws found |
|
|
||
| ARK RTK GPS L1 L5 comes with the Ublox F9P module up to date with version 1.13 or newer. However, you can check the version and update the firmware if desired. | ||
|
|
||
| The steps are: |
There was a problem hiding this comment.
FYI, I just updated this case to use numbering rather than bullets. I recommend but do not require you use numbers for steps that are ordered, and bullets for steps that can be done in any order. That's why I didn't update the steps in "Enabling DroneCAN"
hamishwillee
left a comment
hamishwillee
left a comment
There was a problem hiding this comment.
@patrikpordi Thanks very much for the changes. As commented I made some tweaks for you to look at. I am approving, and will merge tomorrow
3 participants
No description provided.